From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable
Date: Mon, 25 Jul 2011 20:49:00 -0000 [thread overview]
Message-ID: <201107252032.42059.pedro@codesourcery.com> (raw)
In-Reply-To: <m3ei1erwll.fsf@fleche.redhat.com>
On Monday 25 July 2011 20:25:42, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> >> +/* BLOCK_FUNC routine for dcache_free. */
> >> +
> >> +static void
> >> +free_block (struct dcache_block *block, void *param)
> >> +{
> >> + free (block);
>
> Pedro> xfree.
>
> This one is just moving code from one spot to another.
> I don't mind it if Paul wants to fix it, but I think as a rule we
> shouldn't "review the context" and make patch submitters fix nits which
> already appear in the source.
Yes, agreed. I just hadn't noticed the function was just being moved.
Paul, if you want to fix that one, it's preaproved, either as
preparatory patch, or as followup.
--
Pedro Alves
next prev parent reply other threads:[~2011-07-25 19:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 2:40 Paul Pluzhnikov
2011-07-23 16:57 ` Eli Zaretskii
2011-07-25 15:01 ` Tom Tromey
2011-07-25 18:47 ` Paul Pluzhnikov
2011-07-25 19:22 ` Tom Tromey
2011-07-25 19:32 ` Pedro Alves
2011-07-25 19:33 ` Tom Tromey
2011-07-25 20:49 ` Pedro Alves [this message]
2011-07-25 20:22 ` Eli Zaretskii
2011-07-25 21:04 ` Paul Pluzhnikov
2011-07-26 0:28 ` Pedro Alves
2011-07-26 9:51 ` Eli Zaretskii
2011-07-25 19:26 ` Jan Kratochvil
2011-07-25 20:58 ` Paul Pluzhnikov
2011-07-26 2:55 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107252032.42059.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox