From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82612-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3437 invoked by alias); 25 Jul 2011 19:32:31 -0000
Received: (qmail 3427 invoked by uid 22791); 25 Jul 2011 19:32:30 -0000
X-SWARE-Spam-Status: No, hits=-0.9 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jul 2011 19:32:00 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LOW00100M6K8300@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 25 Jul 2011 22:31:58 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.124.68.10]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LOW000IBM98F2C0@a-mtaout20.012.net.il>; Mon, 25 Jul 2011 22:31:57 +0300 (IDT)
Date: Mon, 25 Jul 2011 20:22:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable
In-reply-to: <CALoOobOyyOOBKBOy97se2jcnpWMwQ00_Q9ht775NiAed-HxEsA@mail.gmail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83bowif96z.fsf@gnu.org>
References: <20110722222025.ED9B6190B14@elbrus2.mtv.corp.google.com> <m3tyaatnu5.fsf@fleche.redhat.com> <CALoOobOyyOOBKBOy97se2jcnpWMwQ00_Q9ht775NiAed-HxEsA@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00707.txt.bz2

> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> Date: Mon, 25 Jul 2011 11:32:51 -0700
> Cc: gdb-patches@sourceware.org
> 
> +* Dcache size (number of lines) and line-size are now runtime-configurable.

Please mention the names of the new commands.

> +@item set dcache size @var{size}
> +@cindex dcache size
> +@kindex dcache size

@kindex should say "set dcache size", because @kindex entries are
commands.  Same in other commands you introduced.

> +@item show dcache size
> +@cindex dcache size
> +@kindex dcache size

It's not useful to have identical index entries pointing to the same
page.  Please remove the second instance.

> +Show maximum number of dcache entries. See also @ref{Caching Remote Data, info dcache}.
                                        ^^
Two spaces.

> +@cindex dcache line-size
> +@kindex dcache line-size
> +Show default size of dcache lines. See also @ref{Caching Remote Data, info dcache}.

Same here (both the second index entry and whitespace between
sentences).

OK with those changes.

Thanks.