From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: tromey@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
Date: Wed, 09 Oct 2013 19:08:00 -0000 [thread overview]
Message-ID: <831u3uqn3d.fsf@gnu.org> (raw)
In-Reply-To: <20131009183728.GA22837@host2.jankratochvil.net>
> Date: Wed, 9 Oct 2013 20:37:28 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: tromey@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org
>
> On Wed, 09 Oct 2013 19:58:12 +0200, Eli Zaretskii wrote:
> > Then why did you ask this upthread:
> >
> > > May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails
> > > because of the "e" flag, Kai? It is in GDB function gdb_fopen_cloexec.
> >
> > ? That's what confused me. Sorry if I missed something.
>
> I did not realize / expect O_CLOEXEC is 0 on MS-Windows.
Ah, okay. Then I guess the problem doesn't exist, as "e" will never
be tried in the MinGW build.
> Also MS-Windows has
> many build platforms like MinGW, Cygwin, ActiveState(?), 32 vs. 64 bit, native
> vs. cross, there exist various sets of include files either original or stolen
> by dirty room / clean room approaches, so when we talk about "MS-Windows" here
> do not believe we cover all the possible ways how to build MS-Windows hosted
> GDB.
I was talking about MinGW only.
> But whenever I try to build GDB on a non-Linux platform it fails for me anyway
Well, whenever I build with MinGW on Windows, it always succeeds
(unless there are real bugs in GDB).
Anyway, thanks for clarifying, and sorry for making noise.
prev parent reply other threads:[~2013-10-09 19:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 18:32 Jan Kratochvil
2013-10-08 19:44 ` Tom Tromey
2013-10-09 13:10 ` Jan Kratochvil
2013-10-09 13:34 ` Kai Tietz
2013-10-09 14:41 ` [patchv2] " Jan Kratochvil
2013-10-09 15:48 ` Tom Tromey
2013-10-09 16:01 ` [commit] " Jan Kratochvil
2013-10-09 17:07 ` [patch] " Eli Zaretskii
2013-10-09 17:02 ` Eli Zaretskii
2013-10-09 17:08 ` Tom Tromey
2013-10-09 17:29 ` Eli Zaretskii
2013-10-09 17:41 ` Jan Kratochvil
2013-10-09 17:58 ` Eli Zaretskii
2013-10-09 18:37 ` Jan Kratochvil
2013-10-09 19:08 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831u3uqn3d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ktietz@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox