Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
Date: Tue, 08 Oct 2013 19:44:00 -0000	[thread overview]
Message-ID: <87li23fsym.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20131008183214.GB27355@host2.jankratochvil.net> (Jan	Kratochvil's message of "Tue, 8 Oct 2013 20:32:14 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I just noticed GDB does many needless double-opens with ENOENT like:

Whoops.

Jan> -  if (result == NULL)
Jan> +  if (result != NULL)
Jan> +    fopen_e_ever_succeeded = 1;
Jan> +  else if (!fopen_e_ever_succeeded)

What if we have it check for EINVAL instead?

Tom


  reply	other threads:[~2013-10-08 19:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 18:32 Jan Kratochvil
2013-10-08 19:44 ` Tom Tromey [this message]
2013-10-09 13:10   ` Jan Kratochvil
2013-10-09 13:34     ` Kai Tietz
2013-10-09 14:41       ` [patchv2] " Jan Kratochvil
2013-10-09 15:48         ` Tom Tromey
2013-10-09 16:01           ` [commit] " Jan Kratochvil
2013-10-09 17:07       ` [patch] " Eli Zaretskii
2013-10-09 17:02     ` Eli Zaretskii
2013-10-09 17:08       ` Tom Tromey
2013-10-09 17:29         ` Eli Zaretskii
2013-10-09 17:41           ` Jan Kratochvil
2013-10-09 17:58             ` Eli Zaretskii
2013-10-09 18:37               ` Jan Kratochvil
2013-10-09 19:08                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li23fsym.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox