From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Kai Tietz <ktietz@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
Date: Wed, 09 Oct 2013 13:10:00 -0000 [thread overview]
Message-ID: <20131009131016.GA1603@host2.jankratochvil.net> (raw)
In-Reply-To: <87li23fsym.fsf@fleche.redhat.com>
On Tue, 08 Oct 2013 21:44:33 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> - if (result == NULL)
> Jan> + if (result != NULL)
> Jan> + fopen_e_ever_succeeded = 1;
> Jan> + else if (!fopen_e_ever_succeeded)
>
> What if we have it check for EINVAL instead?
May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails
because of the "e" flag, Kai? It is in GDB function gdb_fopen_cloexec.
original post:
[patch] Minor O_CLOEXEC optimization, "regression" fix
https://sourceware.org/ml/gdb-patches/2013-10/msg00233.html
Thanks,
Jan
next prev parent reply other threads:[~2013-10-09 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 18:32 Jan Kratochvil
2013-10-08 19:44 ` Tom Tromey
2013-10-09 13:10 ` Jan Kratochvil [this message]
2013-10-09 13:34 ` Kai Tietz
2013-10-09 14:41 ` [patchv2] " Jan Kratochvil
2013-10-09 15:48 ` Tom Tromey
2013-10-09 16:01 ` [commit] " Jan Kratochvil
2013-10-09 17:07 ` [patch] " Eli Zaretskii
2013-10-09 17:02 ` Eli Zaretskii
2013-10-09 17:08 ` Tom Tromey
2013-10-09 17:29 ` Eli Zaretskii
2013-10-09 17:41 ` Jan Kratochvil
2013-10-09 17:58 ` Eli Zaretskii
2013-10-09 18:37 ` Jan Kratochvil
2013-10-09 19:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009131016.GA1603@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ktietz@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox