From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106156-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5083 invoked by alias); 9 Oct 2013 13:10:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5071 invoked by uid 89); 9 Oct 2013 13:10:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 13:10:23 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99DAMhB016243	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 9 Oct 2013 09:10:22 -0400
Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r99DAGcu021437	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);	Wed, 9 Oct 2013 09:10:21 -0400
Date: Wed, 09 Oct 2013 13:10:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Kai Tietz <ktietz@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
Message-ID: <20131009131016.GA1603@host2.jankratochvil.net>
References: <20131008183214.GB27355@host2.jankratochvil.net> <87li23fsym.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87li23fsym.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-10/txt/msg00269.txt.bz2

On Tue, 08 Oct 2013 21:44:33 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> -  if (result == NULL)
> Jan> +  if (result != NULL)
> Jan> +    fopen_e_ever_succeeded = 1;
> Jan> +  else if (!fopen_e_ever_succeeded)
> 
> What if we have it check for EINVAL instead?

May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails
because of the "e" flag, Kai?  It is in GDB function gdb_fopen_cloexec.

original post:
	[patch] Minor O_CLOEXEC optimization, "regression" fix
	https://sourceware.org/ml/gdb-patches/2013-10/msg00233.html


Thanks,
Jan