From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24714 invoked by alias); 9 Oct 2013 19:08:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24702 invoked by uid 89); 9 Oct 2013 19:08:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 19:08:12 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MUF0020010U4R00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 09 Oct 2013 22:08:09 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MUF0018U15LX680@a-mtaout20.012.net.il>; Wed, 09 Oct 2013 22:08:09 +0300 (IDT) Date: Wed, 09 Oct 2013 19:08:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix In-reply-to: <20131009183728.GA22837@host2.jankratochvil.net> To: Jan Kratochvil Cc: tromey@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <831u3uqn3d.fsf@gnu.org> References: <20131008183214.GB27355@host2.jankratochvil.net> <87li23fsym.fsf@fleche.redhat.com> <20131009131016.GA1603@host2.jankratochvil.net> <83hacqqsx7.fsf@gnu.org> <87ob6ybcdc.fsf@fleche.redhat.com> <83bo2yqrop.fsf@gnu.org> <20131009174124.GA20135@host2.jankratochvil.net> <837gdmqqbv.fsf@gnu.org> <20131009183728.GA22837@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00317.txt.bz2 > Date: Wed, 9 Oct 2013 20:37:28 +0200 > From: Jan Kratochvil > Cc: tromey@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org > > On Wed, 09 Oct 2013 19:58:12 +0200, Eli Zaretskii wrote: > > Then why did you ask this upthread: > > > > > May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails > > > because of the "e" flag, Kai? It is in GDB function gdb_fopen_cloexec. > > > > ? That's what confused me. Sorry if I missed something. > > I did not realize / expect O_CLOEXEC is 0 on MS-Windows. Ah, okay. Then I guess the problem doesn't exist, as "e" will never be tried in the MinGW build. > Also MS-Windows has > many build platforms like MinGW, Cygwin, ActiveState(?), 32 vs. 64 bit, native > vs. cross, there exist various sets of include files either original or stolen > by dirty room / clean room approaches, so when we talk about "MS-Windows" here > do not believe we cover all the possible ways how to build MS-Windows hosted > GDB. I was talking about MinGW only. > But whenever I try to build GDB on a non-Linux platform it fails for me anyway Well, whenever I build with MinGW on Windows, it always succeeds (unless there are real bugs in GDB). Anyway, thanks for clarifying, and sorry for making noise.