From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Don't abort testrun for invalid command in test-case
Date: Wed, 17 Jun 2020 16:14:25 +0200 [thread overview]
Message-ID: <80251b07-73db-1ca0-7ab6-67285cb6b1d7@suse.de> (raw)
In-Reply-To: <31b0b6f2-4930-f339-0245-3a328d0d2548@redhat.com>
On 6/16/20 2:47 PM, Pedro Alves wrote:
> On 6/11/20 11:55 PM, Tom de Vries wrote:
>
>> Hmm, what is the distinction between gdb_init and default_gdb_init?
>>
>> All the other uses in gdb.exp of pattern foo/default_foo have an
>> implementation:
>> ...
>> proc foo {} {
>> [default_foo]
>> }
>> ...
>> but gdb_init is much more than that. Why is that different?
>>
>
> I don't know. I guess it shouldn't. I guess people (including me) added to
> gdb_init over time without realizing they were breaking the pattern. Maybe nobody
> notices it because whatever is overriding gdb_init renames the original one and
> then calls it.
Hmm, thanks for the explanation. I feel we need to improve this
situation somehow, but I'm not sure yet how.
Thanks,
- Tom
next prev parent reply other threads:[~2020-06-17 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 14:35 Tom de Vries
2020-06-11 15:31 ` Pedro Alves
2020-06-11 16:25 ` Tom de Vries
2020-06-11 16:56 ` Pedro Alves
2020-06-11 22:55 ` Tom de Vries
2020-06-16 12:47 ` Pedro Alves
2020-06-17 14:14 ` Tom de Vries [this message]
2020-06-17 14:19 ` Pedro Alves
2020-06-18 10:16 ` [PATCH][gdb/testsuite] Move code from gdb_init to default_gdb_init Tom de Vries
2020-06-18 10:56 ` Pedro Alves
2020-06-12 7:47 ` [PATCH][gdb/testsuite] Don't abort testrun for invalid command in test-case Tom de Vries
2020-06-12 8:37 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80251b07-73db-1ca0-7ab6-67285cb6b1d7@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox