From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/6] Change representation of psymbol to flush out accessors
Date: Tue, 05 Jun 2018 19:49:00 -0000 [thread overview]
Message-ID: <7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca> (raw)
In-Reply-To: <871sdm5smj.fsf@tromey.com>
On 2018-06-04 14:11, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
>>> + h = hash_continue (&psymbol->pginfo.name, sizeof
>>> (psymbol->pginfo.name), h);
>
> Keith> I realize this is just a renaming of the existing code, but
> since
> Keith> there is an accessor for `name', I think it better to use it (in
> Keith> case someone ends up grepping for this).
> [...]
> Keith> Same here for PSYMBOL_LANGUAGE and PSYMBOL_LINKAGE_NAME?
>
> I've made these changes locally.
>
> Tom
I wanted for a while to convert all these macros to static inline
functions, it just hasn't been high on the todo list. Since you're
adding new code, would you mind making them static inline functions
instead of macros (if you agree with the idea, of course)?
Simon
next prev parent reply other threads:[~2018-06-05 19:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 22:36 [RFA 0/6] Make psymbols independent of the progspace Tom Tromey
2018-05-03 22:36 ` [RFA 4/6] Introduce accessors for psymtab high and low fields Tom Tromey
2018-06-01 20:48 ` Keith Seitz
2018-06-04 18:14 ` Tom Tromey
2018-06-05 21:03 ` Simon Marchi
2018-05-03 22:36 ` [RFA 2/6] Change representation of psymbol to flush out accessors Tom Tromey
2018-06-01 19:19 ` Keith Seitz
2018-06-04 18:11 ` Tom Tromey
2018-06-05 19:49 ` Simon Marchi [this message]
2018-06-05 22:56 ` Tom Tromey
2018-06-05 23:31 ` Simon Marchi
2018-05-03 22:36 ` [RFA 1/6] Remove dead code in end_psymtab Tom Tromey
2018-06-01 18:55 ` Keith Seitz
2018-06-05 19:41 ` Simon Marchi
2018-05-03 22:36 ` [RFA 5/6] Add validity bits for psymtab high and low fields Tom Tromey
2018-06-01 21:23 ` Keith Seitz
2018-06-05 17:25 ` Tom Tromey
2018-06-05 17:38 ` Keith Seitz
2018-05-03 22:36 ` [RFA 6/6] Make psymbols and psymtabs independent of the program space Tom Tromey
2018-06-05 20:34 ` Keith Seitz
2018-05-03 22:36 ` [RFA 3/6] Make PSYMBOL_VALUE_ADDRESS take objfile argument Tom Tromey
2018-06-01 20:06 ` Keith Seitz
2018-06-01 21:03 ` Tom Tromey
2018-06-05 20:50 ` Simon Marchi
2018-05-25 17:58 ` [RFA 0/6] Make psymbols independent of the progspace Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox