From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38877 invoked by alias); 5 Jun 2018 19:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116505 invoked by uid 89); 5 Jun 2018 19:48:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:15d0da9, pginfo.name, accessor, sk:PSYMBOL X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 19:48:25 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w55JmIbv007164 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 5 Jun 2018 15:48:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 81EE41E5AF; Tue, 5 Jun 2018 15:48:18 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 398941E4F7; Tue, 5 Jun 2018 15:48:17 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Jun 2018 19:49:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [RFA 2/6] Change representation of psymbol to flush out accessors In-Reply-To: <871sdm5smj.fsf@tromey.com> References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-3-tom@tromey.com> <15d0da9f-93fa-5d23-ce4e-43d5befe48e7@redhat.com> <871sdm5smj.fsf@tromey.com> Message-ID: <7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Jun 2018 19:48:18 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00115.txt.bz2 On 2018-06-04 14:11, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > >>> + h = hash_continue (&psymbol->pginfo.name, sizeof >>> (psymbol->pginfo.name), h); > > Keith> I realize this is just a renaming of the existing code, but > since > Keith> there is an accessor for `name', I think it better to use it (in > Keith> case someone ends up grepping for this). > [...] > Keith> Same here for PSYMBOL_LANGUAGE and PSYMBOL_LINKAGE_NAME? > > I've made these changes locally. > > Tom I wanted for a while to convert all these macros to static inline functions, it just hasn't been high on the todo list. Since you're adding new code, would you mind making them static inline functions instead of macros (if you agree with the idea, of course)? Simon