Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 1/6] Remove dead code in end_psymtab
Date: Thu, 03 May 2018 22:36:00 -0000	[thread overview]
Message-ID: <20180503223621.22544-2-tom@tromey.com> (raw)
In-Reply-To: <20180503223621.22544-1-tom@tromey.com>

I noticed that there is a bit of dead code in end_psymtab.
This deletes it.

Normally I would investigate a fix for the code.  However, considering
that the code has been this way a long time (since the first import to
sourceware) and considering that dbxread.c is not as important any
more, I think it's safe to just consider that there's no bug.

ChangeLog
2018-05-03  Tom Tromey  <tromey@redhat.com>

	* dbxread.c (end_psymtab): Remove dead code.
---
 gdb/ChangeLog | 4 ++++
 gdb/dbxread.c | 8 +-------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index bdf4fb9c79..7acbb0ec8b 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2105,13 +2105,7 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
       ALL_OBJFILE_PSYMTABS (objfile, p1)
       {
 	if (p1->texthigh == 0 && p1->textlow != 0 && p1 != pst)
-	  {
-	    p1->texthigh = pst->textlow;
-	    /* If this file has only data, then make textlow match
-	       texthigh.  */
-	    if (p1->textlow == 0)
-	      p1->textlow = p1->texthigh;
-	  }
+	  p1->texthigh = pst->textlow;
       }
     }
 
-- 
2.13.6


  parent reply	other threads:[~2018-05-03 22:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:36 [RFA 0/6] Make psymbols independent of the progspace Tom Tromey
2018-05-03 22:36 ` [RFA 5/6] Add validity bits for psymtab high and low fields Tom Tromey
2018-06-01 21:23   ` Keith Seitz
2018-06-05 17:25     ` Tom Tromey
2018-06-05 17:38       ` Keith Seitz
2018-05-03 22:36 ` [RFA 3/6] Make PSYMBOL_VALUE_ADDRESS take objfile argument Tom Tromey
2018-06-01 20:06   ` Keith Seitz
2018-06-01 21:03     ` Tom Tromey
2018-06-05 20:50       ` Simon Marchi
2018-05-03 22:36 ` [RFA 6/6] Make psymbols and psymtabs independent of the program space Tom Tromey
2018-06-05 20:34   ` Keith Seitz
2018-05-03 22:36 ` [RFA 4/6] Introduce accessors for psymtab high and low fields Tom Tromey
2018-06-01 20:48   ` Keith Seitz
2018-06-04 18:14     ` Tom Tromey
2018-06-05 21:03   ` Simon Marchi
2018-05-03 22:36 ` Tom Tromey [this message]
2018-06-01 18:55   ` [RFA 1/6] Remove dead code in end_psymtab Keith Seitz
2018-06-05 19:41     ` Simon Marchi
2018-05-03 22:36 ` [RFA 2/6] Change representation of psymbol to flush out accessors Tom Tromey
2018-06-01 19:19   ` Keith Seitz
2018-06-04 18:11     ` Tom Tromey
2018-06-05 19:49       ` Simon Marchi
2018-06-05 22:56         ` Tom Tromey
2018-06-05 23:31           ` Simon Marchi
2018-05-25 17:58 ` [RFA 0/6] Make psymbols independent of the progspace Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503223621.22544-2-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox