Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/6] Make psymbols independent of the progspace
Date: Fri, 25 May 2018 17:58:00 -0000	[thread overview]
Message-ID: <87sh6fd4h0.fsf@tromey.com> (raw)
In-Reply-To: <20180503223621.22544-1-tom@tromey.com> (Tom Tromey's message of	"Thu, 3 May 2018 16:36:15 -0600")

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> This is another old patch series that I never checked in, which I've
Tom> now rebased.

Tom> Like some earlier series -- most recently for line tables -- This
Tom> series changes partial symbols to be independent of the progspace.
Tom> This means that the data is now stored unrelocated, and could in
Tom> theory be shared across multiple objfiles.

Tom> In practice psymtabs cannot be shared yet, because they have a
Tom> backlink to the full symtab.

Tom> Patches #1-#3 are just infrastructure changes in preparation for the
Tom> main patch; and most of the real work is in patch #6.

Tom> In patch #6 I chose to adjust addresses like this:

Tom>       lo = gdbarch_adjust_dwarf2_addr (gdbarch, lo + baseaddr) - baseaddr;

Tom> I'm not sure if this is the best way.  Maybe in the line table (I
Tom> can't look at this moment and I don't recall offhand) patch I chose to
Tom> pass unrelocated addresses to gdbarch_adjust_dwarf2_addr.  It would be
Tom> good to nail down the intended meaning of this hook and adjust
Tom> accordingly.

Tom> Tested by the buildbot -- but careful review is still required,
Tom> because some of the changes are not tested there.

Ping.

Tom


      parent reply	other threads:[~2018-05-25 17:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:36 Tom Tromey
2018-05-03 22:36 ` [RFA 3/6] Make PSYMBOL_VALUE_ADDRESS take objfile argument Tom Tromey
2018-06-01 20:06   ` Keith Seitz
2018-06-01 21:03     ` Tom Tromey
2018-06-05 20:50       ` Simon Marchi
2018-05-03 22:36 ` [RFA 6/6] Make psymbols and psymtabs independent of the program space Tom Tromey
2018-06-05 20:34   ` Keith Seitz
2018-05-03 22:36 ` [RFA 5/6] Add validity bits for psymtab high and low fields Tom Tromey
2018-06-01 21:23   ` Keith Seitz
2018-06-05 17:25     ` Tom Tromey
2018-06-05 17:38       ` Keith Seitz
2018-05-03 22:36 ` [RFA 2/6] Change representation of psymbol to flush out accessors Tom Tromey
2018-06-01 19:19   ` Keith Seitz
2018-06-04 18:11     ` Tom Tromey
2018-06-05 19:49       ` Simon Marchi
2018-06-05 22:56         ` Tom Tromey
2018-06-05 23:31           ` Simon Marchi
2018-05-03 22:36 ` [RFA 1/6] Remove dead code in end_psymtab Tom Tromey
2018-06-01 18:55   ` Keith Seitz
2018-06-05 19:41     ` Simon Marchi
2018-05-03 22:36 ` [RFA 4/6] Introduce accessors for psymtab high and low fields Tom Tromey
2018-06-01 20:48   ` Keith Seitz
2018-06-04 18:14     ` Tom Tromey
2018-06-05 21:03   ` Simon Marchi
2018-05-25 17:58 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh6fd4h0.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox