Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.

[Jiang Jilin <freephp@gmail.com>]

On Sat, Oct 10, 2009 at 10:33 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Sorry, but I don't know how to verify it, please help me with it. When
>> I ran 'make check', it displayed some 'FAIL' messages even before my
>> patch, and I noticed runtest uses
>> /usr/share/dejagnu/baseboards/unix.exp, which is not given by
>> http://sourceware.org/gdb/wiki/ReversibleDebugging.  How to use
>> runtest to test precord.exp only?
>
> I will let Michael and Hui explain to you how to use the special
> board file precord.exp.

OK. Thank you!

Another question: when to verify whether regression occurs, is 'make
check' enough? or have to test all other *.exp in /usr/share/dejagnu/baseboards?

> The FAILs are expected, as is simply impossible to mark all failures
> for all platforms.  There are too many variables, such as your compiler,
> your kernel, etc etc etc.  So what you need to do is run the testsuite
> before and after your patch, saving the contents of gdb.sum after the
> first run, and then do a comparison of the two files, to make sure
> that your patch did not cause any unexpected change.  Some tests are
> a little unpredictable, and cause you to see some apparent regressions
> that may not be caused by your patch. You'll have to use your judgement
> in these cases.

I got it, the key is diff the gdb.sum.

>> No, I don't have an FSF  assignment on file, but I'd like to. How to
>> have an FSF assignment on file?
>
> I'll send you the form to fill in and send to the FSF immediately.
>

Thank you very much!

> Joel
>



-- 
Jiang