From: Joel Brobecker <brobecker@adacore.com>
To: Jiang Jilin <freephp@gmail.com>
Cc: Hui Zhu <teawater@gmail.com>, Michael Snyder <msnyder@vmware.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.
Date: Fri, 09 Oct 2009 17:21:00 -0000 [thread overview]
Message-ID: <20091009172119.GA5272@adacore.com> (raw)
In-Reply-To: <1255095434-30271-1-git-send-email-freephp@gmail.com>
> 2009-10-09 Jiang Jilin <freephp@gmail.com>
>
> * i386-tdep.c (i386_process_record): Add xgetbv/xsetbv instructions support
I will trust you on the instruction analysis and testing of your patch.
If you ran the testsuite to verify that there is no regression before
and after your patch (please confirm), then this patch is approved.
Just one minor nit: The line in the ChangeLog needs to be split as
it goes beyond 80 columns.
I could not locate you in our FSF assignment database. Do you have
an FSF assignment on file? If not, I don't think we can take this
contribution until you do (too large to be taken as an obvious change
or what we call a "tiny change"). Let us know whether you do or do not,
and whether you'd like to get you started on the paperwork. It takes
a few weeks, so should we need it, sooner would be better than later.
--
Joel
next prev parent reply other threads:[~2009-10-09 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 13:37 Jiang Jilin
2009-10-09 17:21 ` Joel Brobecker [this message]
[not found] ` <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com>
2009-10-10 2:33 ` Joel Brobecker
2009-10-10 2:46 ` Jiang Jilin
2009-10-10 4:59 ` Joel Brobecker
2009-10-10 7:57 ` Hui Zhu
2009-10-10 8:10 ` Jiang Jilin
2009-10-10 8:14 ` Jiang Jilin
2009-10-09 22:26 ` Michael Snyder
2009-10-12 8:00 ` Jiang Jilin
2009-10-12 15:43 ` Michael Snyder
2009-10-13 8:48 ` Jiang Jilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009172119.GA5272@adacore.com \
--to=brobecker@adacore.com \
--cc=freephp@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox