Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jiang Jilin <freephp@gmail.com>
Cc: Hui Zhu <teawater@gmail.com>, Michael Snyder <msnyder@vmware.com>,
		gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.
Date: Sat, 10 Oct 2009 02:33:00 -0000	[thread overview]
Message-ID: <20091010023344.GD5272@adacore.com> (raw)
In-Reply-To: <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com>

> Sorry, but I don't know how to verify it, please help me with it. When
> I ran 'make check', it displayed some 'FAIL' messages even before my
> patch, and I noticed runtest uses
> /usr/share/dejagnu/baseboards/unix.exp, which is not given by
> http://sourceware.org/gdb/wiki/ReversibleDebugging.  How to use
> runtest to test precord.exp only?

I will let Michael and Hui explain to you how to use the special
board file precord.exp.

The FAILs are expected, as is simply impossible to mark all failures
for all platforms.  There are too many variables, such as your compiler,
your kernel, etc etc etc.  So what you need to do is run the testsuite
before and after your patch, saving the contents of gdb.sum after the
first run, and then do a comparison of the two files, to make sure
that your patch did not cause any unexpected change.  Some tests are
a little unpredictable, and cause you to see some apparent regressions
that may not be caused by your patch. You'll have to use your judgement
in these cases.

> No, I don't have an FSF  assignment on file, but I'd like to. How to
> have an FSF assignment on file?

I'll send you the form to fill in and send to the FSF immediately.

-- 
Joel


  parent reply	other threads:[~2009-10-10  2:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 13:37 Jiang Jilin
2009-10-09 17:21 ` Joel Brobecker
     [not found]   ` <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com>
2009-10-10  2:33     ` Joel Brobecker [this message]
2009-10-10  2:46       ` Jiang Jilin
2009-10-10  4:59         ` Joel Brobecker
2009-10-10  7:57       ` Hui Zhu
2009-10-10  8:10         ` Jiang Jilin
2009-10-10  8:14         ` Jiang Jilin
2009-10-09 22:26 ` Michael Snyder
2009-10-12  8:00   ` Jiang Jilin
2009-10-12 15:43     ` Michael Snyder
2009-10-13  8:48       ` Jiang Jilin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091010023344.GD5272@adacore.com \
    --to=brobecker@adacore.com \
    --cc=freephp@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox