From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11104 invoked by alias); 10 Oct 2009 02:33:54 -0000 Received: (qmail 11091 invoked by uid 22791); 10 Oct 2009 02:33:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Oct 2009 02:33:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 31EB62BACA0; Fri, 9 Oct 2009 22:33:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5UVH0wk4aFuv; Fri, 9 Oct 2009 22:33:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D316E2BAB1A; Fri, 9 Oct 2009 22:33:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9826AF589F; Fri, 9 Oct 2009 19:33:44 -0700 (PDT) Date: Sat, 10 Oct 2009 02:33:00 -0000 From: Joel Brobecker To: Jiang Jilin Cc: Hui Zhu , Michael Snyder , gdb-patches ml Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. Message-ID: <20091010023344.GD5272@adacore.com> References: <1255095434-30271-1-git-send-email-freephp@gmail.com> <20091009172119.GA5272@adacore.com> <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00199.txt.bz2 > Sorry, but I don't know how to verify it, please help me with it. When > I ran 'make check', it displayed some 'FAIL' messages even before my > patch, and I noticed runtest uses > /usr/share/dejagnu/baseboards/unix.exp, which is not given by > http://sourceware.org/gdb/wiki/ReversibleDebugging. How to use > runtest to test precord.exp only? I will let Michael and Hui explain to you how to use the special board file precord.exp. The FAILs are expected, as is simply impossible to mark all failures for all platforms. There are too many variables, such as your compiler, your kernel, etc etc etc. So what you need to do is run the testsuite before and after your patch, saving the contents of gdb.sum after the first run, and then do a comparison of the two files, to make sure that your patch did not cause any unexpected change. Some tests are a little unpredictable, and cause you to see some apparent regressions that may not be caused by your patch. You'll have to use your judgement in these cases. > No, I don't have an FSF assignment on file, but I'd like to. How to > have an FSF assignment on file? I'll send you the form to fill in and send to the FSF immediately. -- Joel