From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8760 invoked by alias); 9 Oct 2009 17:21:31 -0000 Received: (qmail 8749 invoked by uid 22791); 9 Oct 2009 17:21:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Oct 2009 17:21:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 259722BACAE; Fri, 9 Oct 2009 13:21:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dmB+C7zAxxd4; Fri, 9 Oct 2009 13:21:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CA4CD2BACA1; Fri, 9 Oct 2009 13:21:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1C2CEF589F; Fri, 9 Oct 2009 10:21:19 -0700 (PDT) Date: Fri, 09 Oct 2009 17:21:00 -0000 From: Joel Brobecker To: Jiang Jilin Cc: Hui Zhu , Michael Snyder , gdb-patches ml Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. Message-ID: <20091009172119.GA5272@adacore.com> References: <1255095434-30271-1-git-send-email-freephp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1255095434-30271-1-git-send-email-freephp@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00192.txt.bz2 > 2009-10-09 Jiang Jilin > > * i386-tdep.c (i386_process_record): Add xgetbv/xsetbv instructions support I will trust you on the instruction analysis and testing of your patch. If you ran the testsuite to verify that there is no regression before and after your patch (please confirm), then this patch is approved. Just one minor nit: The line in the ChangeLog needs to be split as it goes beyond 80 columns. I could not locate you in our FSF assignment database. Do you have an FSF assignment on file? If not, I don't think we can take this contribution until you do (too large to be taken as an obvious change or what we call a "tiny change"). Let us know whether you do or do not, and whether you'd like to get you started on the paperwork. It takes a few weeks, so should we need it, sooner would be better than later. -- Joel