From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26142 invoked by alias); 10 Oct 2009 02:46:13 -0000 Received: (qmail 26128 invoked by uid 22791); 10 Oct 2009 02:46:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from qw-out-1920.google.com (HELO qw-out-1920.google.com) (74.125.92.144) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Oct 2009 02:46:03 +0000 Received: by qw-out-1920.google.com with SMTP id 5so3345708qwc.24 for ; Fri, 09 Oct 2009 19:46:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.93.41 with SMTP id t41mr1920448qcm.81.1255142761808; Fri, 09 Oct 2009 19:46:01 -0700 (PDT) In-Reply-To: <20091010023344.GD5272@adacore.com> References: <1255095434-30271-1-git-send-email-freephp@gmail.com> <20091009172119.GA5272@adacore.com> <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com> <20091010023344.GD5272@adacore.com> From: Jiang Jilin Date: Sat, 10 Oct 2009 02:46:00 -0000 Message-ID: <7d77a27d0910091945l1de79c02u1f111bd3b193b144@mail.gmail.com> Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. To: Joel Brobecker Cc: Hui Zhu , Michael Snyder , gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00200.txt.bz2 On Sat, Oct 10, 2009 at 10:33 AM, Joel Brobecker wr= ote: >> Sorry, but I don't know how to verify it, please help me with it. When >> I ran 'make check', it displayed some 'FAIL' messages even before my >> patch, and I noticed runtest uses >> /usr/share/dejagnu/baseboards/unix.exp, which is not given by >> http://sourceware.org/gdb/wiki/ReversibleDebugging. =A0How to use >> runtest to test precord.exp only? > > I will let Michael and Hui explain to you how to use the special > board file precord.exp. OK. Thank you! Another question: when to verify whether regression occurs, is 'make check' enough? or have to test all other *.exp in /usr/share/dejagnu/basebo= ards? > The FAILs are expected, as is simply impossible to mark all failures > for all platforms. =A0There are too many variables, such as your compiler, > your kernel, etc etc etc. =A0So what you need to do is run the testsuite > before and after your patch, saving the contents of gdb.sum after the > first run, and then do a comparison of the two files, to make sure > that your patch did not cause any unexpected change. =A0Some tests are > a little unpredictable, and cause you to see some apparent regressions > that may not be caused by your patch. You'll have to use your judgement > in these cases. I got it, the key is diff the gdb.sum. >> No, I don't have an FSF =A0assignment on file, but I'd like to. How to >> have an FSF assignment on file? > > I'll send you the form to fill in and send to the FSF immediately. > Thank you very much! > Joel > --=20 Jiang