From: John Baldwin <jhb@FreeBSD.org>
To: Jim Wilson <jimw@sifive.com>
Cc: gdb-patches@sourceware.org,
Andrew Burgess <andrew.burgess@embecosm.com>,
Palmer Dabbelt <palmer@sifive.com>
Subject: Re: [PATCH 2/4] Fall back to a default value of 0 for the MISA register.
Date: Thu, 20 Sep 2018 22:55:00 -0000 [thread overview]
Message-ID: <786488ee-1578-0393-32a2-2f1918572c89@FreeBSD.org> (raw)
In-Reply-To: <CAFyWVaYAjyDrcLVx7v=dHuV7T_ke55cQ8GEc4Y7z9RLUZKxgbQ@mail.gmail.com>
On 9/20/18 1:56 PM, Jim Wilson wrote:
> On Thu, Sep 20, 2018 at 1:31 PM John Baldwin <jhb@freebsd.org> wrote:
>> Use the existing instruction to determine the RISC-V breakpoint kind.
>
> Yes, this looks like a nice solution to the problem.
>
> In riscv_breakpoint_kind_from_pc, you are setting a byte_order local
> variable but not obviously using it. You presumably don't need byte
> order here as you are only reading one byte.
Oh, very true. I had just copied it from riscv_insn::fetch_instruction.
I'll fix and post a V2.
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2018-09-20 22:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 23:20 [PATCH 0/4] Initial support for FreeBSD/riscv John Baldwin
2018-09-19 23:21 ` [PATCH 3/4] Add FreeBSD/riscv architecture John Baldwin
2018-09-19 23:21 ` [PATCH 2/4] Fall back to a default value of 0 for the MISA register John Baldwin
2018-09-20 0:09 ` Jim Wilson
2018-09-20 0:40 ` John Baldwin
2018-09-20 20:31 ` John Baldwin
2018-09-20 20:57 ` Jim Wilson
2018-09-20 22:55 ` John Baldwin [this message]
2018-09-20 21:51 ` Andrew Burgess
2018-09-20 23:01 ` John Baldwin
2018-09-21 9:27 ` Andrew Burgess
2018-09-21 17:26 ` Jim Wilson
2018-09-28 9:44 ` Andrew Burgess
2018-09-28 18:25 ` Palmer Dabbelt
2018-09-24 20:35 ` John Baldwin
2018-09-19 23:21 ` [PATCH 1/4] Add helper functions to trad_frame to support register cache maps John Baldwin
2018-09-19 23:29 ` [PATCH 4/4] Add native target for FreeBSD/riscv John Baldwin
2018-09-20 4:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786488ee-1578-0393-32a2-2f1918572c89@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox