From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90274 invoked by alias); 20 Sep 2018 22:55:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89695 invoked by uid 89); 20 Sep 2018 22:55:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:771, HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Sep 2018 22:54:58 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 7E76010B68A; Thu, 20 Sep 2018 18:54:56 -0400 (EDT) Subject: Re: [PATCH 2/4] Fall back to a default value of 0 for the MISA register. To: Jim Wilson References: <20180919231950.22634-1-jhb@FreeBSD.org> <20180919231950.22634-3-jhb@FreeBSD.org> <0081bdf8-04cb-f6b7-d80a-d9a878d0a3ab@FreeBSD.org> Cc: gdb-patches@sourceware.org, Andrew Burgess , Palmer Dabbelt From: John Baldwin Message-ID: <786488ee-1578-0393-32a2-2f1918572c89@FreeBSD.org> Date: Thu, 20 Sep 2018 22:55:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00744.txt.bz2 On 9/20/18 1:56 PM, Jim Wilson wrote: > On Thu, Sep 20, 2018 at 1:31 PM John Baldwin wrote: >> Use the existing instruction to determine the RISC-V breakpoint kind. > > Yes, this looks like a nice solution to the problem. > > In riscv_breakpoint_kind_from_pc, you are setting a byte_order local > variable but not obviously using it. You presumably don't need byte > order here as you are only reading one byte. Oh, very true. I had just copied it from riscv_insn::fetch_instruction. I'll fix and post a V2. -- John Baldwin                                                                            Â