From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 06/10] Use symfile_bfd in more places
Date: Fri, 16 Jan 2026 23:19:35 -0500 [thread overview]
Message-ID: <777f675d-4a19-4799-aed5-bfffac5e3ff0@simark.ca> (raw)
In-Reply-To: <c8ce723f-3368-4422-ac6c-246e2acd025a@simark.ca>
On 2026-01-16 23:09, Simon Marchi wrote:
>
>
> On 2026-01-16 14:11, Tom Tromey wrote:
>> Since coffread.c is setting symfile_bfd, it might as well use it
>> everywhere. This changes all other BFD references in coffread.c to
>> use the global.
>
> I think you should just remove symfile_bfd too.
>
> - add a bfd parameter to read_one_sym
> - coff_symtab_read can pass objfile->obfd to read_one_sym
> - init_stringtab refers to symfile_bfd, but it already receives the
> same bfd by parameter, so it can just use the parameter
Heh, this should have been in reply to patch 5. Anyway, you can
disregard this comment, given that this is all replaced with a reader
object at the end. I should really read whole series before commenting
on individual patches to know what the end goal is.
Simon
next prev parent reply other threads:[~2026-01-17 4:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 19:11 [PATCH 00/10] More coffread cleanups Tom Tromey
2026-01-16 19:11 ` [PATCH 01/10] Constify coffread.c:getsymname Tom Tromey
2026-01-16 19:11 ` [PATCH 02/10] Clean up a comment in coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 03/10] Fix indentation " Tom Tromey
2026-01-17 3:54 ` Simon Marchi
2026-01-20 15:47 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 04/10] Change coffread.c:pe_file to bool Tom Tromey
2026-01-16 19:11 ` [PATCH 05/10] Remove redundant nlist_bfd_global Tom Tromey
2026-01-16 19:11 ` [PATCH 06/10] Use symfile_bfd in more places Tom Tromey
2026-01-17 4:09 ` Simon Marchi
2026-01-17 4:19 ` Simon Marchi [this message]
2026-01-17 4:10 ` Simon Marchi
2026-01-16 19:11 ` [PATCH 07/10] Use coffread_objfile throughout coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 08/10] Remove coff_symfile_init Tom Tromey
2026-01-17 4:13 ` Simon Marchi
2026-01-20 15:54 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 09/10] Remove all globals from coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 10/10] Change is_import_fixup_symbol to return bool Tom Tromey
2026-01-17 4:20 ` [PATCH 00/10] More coffread cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777f675d-4a19-4799-aed5-bfffac5e3ff0@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox