From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 10/10] Change is_import_fixup_symbol to return bool
Date: Fri, 16 Jan 2026 12:11:38 -0700 [thread overview]
Message-ID: <20260116-coffread-cleanups-v1-10-4d46090fad69@adacore.com> (raw)
In-Reply-To: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com>
This changes the is_import_fixup_symbol in coffread.c to return bool
rather than int.
---
gdb/coffread.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/coffread.c b/gdb/coffread.c
index 9716bdceaec..fdfc67c8b3a 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -95,7 +95,7 @@ struct coff_reader
asection *cs_to_bfd_section (coff_symbol *cs);
int cs_to_section (coff_symbol *cs);
CORE_ADDR cs_section_address (coff_symbol *cs);
- int is_import_fixup_symbol (coff_symbol *cs, minimal_symbol_type type);
+ bool is_import_fixup_symbol (coff_symbol *cs, minimal_symbol_type type);
minimal_symbol *record_minimal_symbol (minimal_symbol_reader &reader,
coff_symbol *cs,
unrelocated_addr address,
@@ -148,9 +148,9 @@ coff_reader::cs_section_address (struct coff_symbol *cs)
/* The linker sometimes generates some non-function symbols inside
functions referencing variables imported from another DLL.
- Return nonzero if the given symbol corresponds to one of them. */
+ Return true if the given symbol corresponds to one of them. */
-int
+bool
coff_reader::is_import_fixup_symbol (struct coff_symbol *cs,
enum minimal_symbol_type type)
{
@@ -160,23 +160,23 @@ coff_reader::is_import_fixup_symbol (struct coff_symbol *cs,
/* Must be a non-static text symbol. */
if (type != mst_text)
- return 0;
+ return false;
/* Must be a non-function symbol. */
if (ISFCN (cs->c_type))
- return 0;
+ return false;
/* The name must start with "__fu<digits>__". */
if (!startswith (cs->c_name, "__fu"))
- return 0;
+ return false;
if (! c_isdigit (cs->c_name[4]))
- return 0;
+ return false;
for (i = 5; cs->c_name[i] != '\0' && c_isdigit (cs->c_name[i]); i++)
/* Nothing, just incrementing index past all digits. */;
if (cs->c_name[i] != '_' || cs->c_name[i + 1] != '_')
- return 0;
+ return false;
- return 1;
+ return true;
}
struct minimal_symbol *
--
2.52.0
next prev parent reply other threads:[~2026-01-16 19:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 19:11 [PATCH 00/10] More coffread cleanups Tom Tromey
2026-01-16 19:11 ` [PATCH 01/10] Constify coffread.c:getsymname Tom Tromey
2026-01-16 19:11 ` [PATCH 02/10] Clean up a comment in coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 03/10] Fix indentation " Tom Tromey
2026-01-17 3:54 ` Simon Marchi
2026-01-20 15:47 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 04/10] Change coffread.c:pe_file to bool Tom Tromey
2026-01-16 19:11 ` [PATCH 05/10] Remove redundant nlist_bfd_global Tom Tromey
2026-01-16 19:11 ` [PATCH 06/10] Use symfile_bfd in more places Tom Tromey
2026-01-17 4:09 ` Simon Marchi
2026-01-17 4:19 ` Simon Marchi
2026-01-17 4:10 ` Simon Marchi
2026-01-16 19:11 ` [PATCH 07/10] Use coffread_objfile throughout coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 08/10] Remove coff_symfile_init Tom Tromey
2026-01-17 4:13 ` Simon Marchi
2026-01-20 15:54 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 09/10] Remove all globals from coffread.c Tom Tromey
2026-01-16 19:11 ` Tom Tromey [this message]
2026-01-17 4:20 ` [PATCH 00/10] More coffread cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-coffread-cleanups-v1-10-4d46090fad69@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox