From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cbb6BpiRammzqgYAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 14:29:28 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=evnwGzVX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 181B21E0DD; Fri, 16 Jan 2026 14:29:28 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D9911E08D for ; Fri, 16 Jan 2026 14:29:27 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7258A4BA2E35 for ; Fri, 16 Jan 2026 19:29:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7258A4BA2E35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=evnwGzVX Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id A68614BA2E32 for ; Fri, 16 Jan 2026 19:11:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A68614BA2E32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A68614BA2E32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590702; cv=none; b=M/hlO/sp1ICohlaepUPKQLTCamlVDs1U4fiPasqOCPI/z2B63uT3K7SpoQ358boZcv8lacP8qATI4I4uJKShWOLZJqmEMm2NnRO8awPav8bO3ZbTr11XphHGgUmO5C0oVxUFC2h9xU8lBkL/F6pjmN6SXxTh5cYGVdz1kHfbkbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590702; c=relaxed/simple; bh=rqaj1HuHE5MKs305T4wPU2k9IvOM+Yb8X3Ai9OzKE5Y=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Qx1VGOVYbMQcszH4CLUBQKPsLVpAYD1sGCaLV7HjhSm5ppEC6UbFcMVaEwytI5XSjeUi5CNmDMb+oXkYn7E4CqvFsN+a67hZrJBIjP6OcQCyeTzxp5GmGrDUASt3QpvqLtG4b6UxvVIzoJ0iOecd1dVtbbqdQjUPNC+ru+6k89k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A68614BA2E32 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-45c87d82bd2so1648536b6e.1 for ; Fri, 16 Jan 2026 11:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1768590702; x=1769195502; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AgjArLIb+/cMyHfIG2uV6PT3OTdGrwHM57xoEYDNaIg=; b=evnwGzVXHwt83dSpD8x1erzGG7iqX7g4OOuR19oAdrf223F6TRfUUb57ErbsN09tdT v8X8OAddt33goebCyYHRX+yLQ3FbGId5Evp3RGSqFDv01KX0T2IeKZRchvlEi4PY1uYH pVS77Wt2CmhpCPieguSw9XNYTW6L10TyJtWkXi3w4JfqT4U+Y0MT4R2JS311YZNXrnzs c3GuCY3p3CdPz8VOVNvmGvoPN0j33ukv7zTMg91eFlNRYDqw6iUjRUR5KbnphJA+T0wG qZ3Xf/tv1GteOrKOaBxrnnDcp9Vq0vrqgbJ4S46cyxrYXUxdsVqiqFUoJSP5iHWecN4f 324Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768590702; x=1769195502; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AgjArLIb+/cMyHfIG2uV6PT3OTdGrwHM57xoEYDNaIg=; b=tmOnLQUqRTUu0IB/4zLoIU8SwXxo/iGLybtJUwh1bmX4a2ffuVoIqvUnyKSKVlvh7g /q/udppaiDTSzvFmaA5Wzyu9S3g0NdtIHHT5BgH3q1UiSqpvoiBCQB6FmRjmAvyDuNwK XQsSUG5gCGpRwhy1Vn2mA4YVsKzN0LPGHnof8x4u5iD0W9rz3578jlxO68JnvQXP2Lj8 sVVAR1QoEqsQnqp4prvAN3gRn1AnILrnbNaysC9bv17xOvDSp9YK6NAvMrlgnI1uw7Rr T9YDaQ0hs4Y/OgGXrDurzNiCyLKASebT8N5aZ6FFkV+3uUSc/MGmQ8l9vY5GaGiK+88P 4Hog== X-Gm-Message-State: AOJu0Yz74ZDRy5Ibn6IdLUqlq6xjUSm72n6Fn63nwQW1B6zjwuST/Emn cj2AjB+M2E+YcKjChCr9UQloLftVHxsDuZFOQfsgfjLst5wCARwjMGt/gfq4WURgVg== X-Gm-Gg: AY/fxX4wZieT2rbMiuqIt1mTxzXcsijI3hUk43RqXUSZULN1IYuo8UfziNAu7g1T/jW i7CTfYNJd+5zvt/RhnGNBIpskGvUC1mqr+SGzfcW39sMJg7/D+dk6Y1QSD5iPoweo2wDhfIaee7 Gfb6NTllF7n+a5ZSZuTzgQWAhVKQqMCk5BfIAksSnn5BOpL81N3Ch7jR6BdsOnReLIcvHYFzHMV MaYWNZAc1mIkLbbW4o5mA3ijT1+Z66NNrvdAYPTt/bVsNuALwqzCM9wM6QQPhlN4l6urWYdJPbu iYinsIosuy6z0y2GnK9UxsVlLK9sV2QUTiG9syeTzDQnDgp3QUVc80mt/l84roa7vYcFT3NV+IP PSIwo0hTj9rqga6IXhbIPT1f8qNPgIMh6gQgqR0zz1uF/z1ocNt8izlQWy14Sbi3lnLfJ6GtMOZ V47/stLPYQonCDKNjvjLTMCoHK/RJaJu12ubNboZBODA== X-Received: by 2002:a05:6808:2393:b0:450:ac94:5ee1 with SMTP id 5614622812f47-45c9bff3680mr1702811b6e.27.1768590697225; Fri, 16 Jan 2026 11:11:37 -0800 (PST) Received: from [192.168.0.26] (97-122-114-32.hlrn.qwest.net. [97.122.114.32]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf0db2c1sm2196681a34.5.2026.01.16.11.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:11:36 -0800 (PST) From: Tom Tromey Date: Fri, 16 Jan 2026 12:11:38 -0700 Subject: [PATCH 10/10] Change is_import_fixup_symbol to return bool MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260116-coffread-cleanups-v1-10-4d46090fad69@adacore.com> References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> In-Reply-To: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes the is_import_fixup_symbol in coffread.c to return bool rather than int. --- gdb/coffread.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index 9716bdceaec..fdfc67c8b3a 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -95,7 +95,7 @@ struct coff_reader asection *cs_to_bfd_section (coff_symbol *cs); int cs_to_section (coff_symbol *cs); CORE_ADDR cs_section_address (coff_symbol *cs); - int is_import_fixup_symbol (coff_symbol *cs, minimal_symbol_type type); + bool is_import_fixup_symbol (coff_symbol *cs, minimal_symbol_type type); minimal_symbol *record_minimal_symbol (minimal_symbol_reader &reader, coff_symbol *cs, unrelocated_addr address, @@ -148,9 +148,9 @@ coff_reader::cs_section_address (struct coff_symbol *cs) /* The linker sometimes generates some non-function symbols inside functions referencing variables imported from another DLL. - Return nonzero if the given symbol corresponds to one of them. */ + Return true if the given symbol corresponds to one of them. */ -int +bool coff_reader::is_import_fixup_symbol (struct coff_symbol *cs, enum minimal_symbol_type type) { @@ -160,23 +160,23 @@ coff_reader::is_import_fixup_symbol (struct coff_symbol *cs, /* Must be a non-static text symbol. */ if (type != mst_text) - return 0; + return false; /* Must be a non-function symbol. */ if (ISFCN (cs->c_type)) - return 0; + return false; /* The name must start with "__fu__". */ if (!startswith (cs->c_name, "__fu")) - return 0; + return false; if (! c_isdigit (cs->c_name[4])) - return 0; + return false; for (i = 5; cs->c_name[i] != '\0' && c_isdigit (cs->c_name[i]); i++) /* Nothing, just incrementing index past all digits. */; if (cs->c_name[i] != '_' || cs->c_name[i + 1] != '_') - return 0; + return false; - return 1; + return true; } struct minimal_symbol * -- 2.52.0