From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 00/10] More coffread cleanups
Date: Fri, 16 Jan 2026 12:11:28 -0700 [thread overview]
Message-ID: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> (raw)
After Simon removed a huge chunk of coffread.c, I noticed there were
more cleanups that could be done. This series is the result.
I'm not totally certain how to test this, but I did at least run the
resulting gdb on some Windows object files to make sure nothing
untoward happens.
Signed-off-by: Tom Tromey <tromey@adacore.com>
---
Tom Tromey (10):
Constify coffread.c:getsymname
Clean up a comment in coffread.c
Fix indentation in coffread.c
Change coffread.c:pe_file to bool
Remove redundant nlist_bfd_global
Use symfile_bfd in more places
Use coffread_objfile throughout coffread.c
Remove coff_symfile_init
Remove all globals from coffread.c
Change is_import_fixup_symbol to return bool
gdb/coffread.c | 327 ++++++++++++++++++++++++++++-----------------------------
1 file changed, 158 insertions(+), 169 deletions(-)
---
base-commit: 03375540de733c30feae892db8075eebef946383
change-id: 20260116-coffread-cleanups-4bf0b45c8b04
Best regards,
--
Tom Tromey <tromey@adacore.com>
next reply other threads:[~2026-01-16 19:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 19:11 Tom Tromey [this message]
2026-01-16 19:11 ` [PATCH 01/10] Constify coffread.c:getsymname Tom Tromey
2026-01-16 19:11 ` [PATCH 02/10] Clean up a comment in coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 03/10] Fix indentation " Tom Tromey
2026-01-17 3:54 ` Simon Marchi
2026-01-20 15:47 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 04/10] Change coffread.c:pe_file to bool Tom Tromey
2026-01-16 19:11 ` [PATCH 05/10] Remove redundant nlist_bfd_global Tom Tromey
2026-01-16 19:11 ` [PATCH 06/10] Use symfile_bfd in more places Tom Tromey
2026-01-17 4:09 ` Simon Marchi
2026-01-17 4:19 ` Simon Marchi
2026-01-17 4:10 ` Simon Marchi
2026-01-16 19:11 ` [PATCH 07/10] Use coffread_objfile throughout coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 08/10] Remove coff_symfile_init Tom Tromey
2026-01-17 4:13 ` Simon Marchi
2026-01-20 15:54 ` Tom Tromey
2026-01-16 19:11 ` [PATCH 09/10] Remove all globals from coffread.c Tom Tromey
2026-01-16 19:11 ` [PATCH 10/10] Change is_import_fixup_symbol to return bool Tom Tromey
2026-01-17 4:20 ` [PATCH 00/10] More coffread cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox