From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ASeuFjCOamn5pQYAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 14:14:56 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=XYze6OtE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5712B1E0DD; Fri, 16 Jan 2026 14:14:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5AE11E08D for ; Fri, 16 Jan 2026 14:14:55 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B36FB4BA2E27 for ; Fri, 16 Jan 2026 19:14:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B36FB4BA2E27 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=XYze6OtE Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 42C394BA2E3D for ; Fri, 16 Jan 2026 19:11:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42C394BA2E3D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42C394BA2E3D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590696; cv=none; b=FlZIJI8XZ+mWSwfC7IVeHqF2ELvAGWKQftbMd4WvJadIJSrFDk6mMs5WE5oyhwqqA5VyjTKhu4WYrCIFXbdiAm71WS0Jz0hl+E2TAsRHILPSfMghTM+hK/oKjGwC6W2EOwurHkmssrHvfTZTBBlDrU7C72dDNeQjSzWacxXiDXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590696; c=relaxed/simple; bh=RcB93bPSZ5YWBO3GulGkMN7g+Sx7JATUcip+06dLv+M=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=hJEL9sxnyJEdrXgTbOK8FWfIGmile+IM7BJc3Se366aUq0FfZunJdj1xhfL2J7c7iztWCudVAcZYSBZxGETcedVOlfc1RczYrylPcgoktl1BmEh3IhFGqQQg3H5a2p9BjF4YohZriTvhmpn4LA51NVFz8f3Q1aIn5yEmyf2in5A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42C394BA2E3D Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7cfd7d33b88so829008a34.0 for ; Fri, 16 Jan 2026 11:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1768590695; x=1769195495; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ln/E0lynJ7vSTIkLRxP2SyNm1jpIxfdNUeCDum305K4=; b=XYze6OtExXs0tBAdJWerstHzeHCXo5mGfD5YBxhcmaO7+h5ZSHXqNQMEvpXXsC4wjL A4mG+Tv1SQgIff5ykcAF7FhhA2daeBde8IrIxT012VS8cPA2t5mpuj0P+mKv/X9N5PuX h1CtGJuFZilId5+c2IJ4Af4apkCRRo0rVD3L2lIW9DeVnJSpoSNCEVUBeQrQw8ReWl3e HWqgWPHhrct/ys5jiou64FSg41NJL2b/Hz+pMS0osZwUtg448ndw+e3pEcv1j2+Hki7X VnEor3rg82f2wASN6zhr25rwx2KiaUIxNNS1cMhr7CZmq6xNrHETLLTbc4E6sveGNL0V 7IhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768590695; x=1769195495; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ln/E0lynJ7vSTIkLRxP2SyNm1jpIxfdNUeCDum305K4=; b=xUd5OeK/SHwWkCDgYoVFBbD+zOo0VKPDjqrjPyJtYLU6pyysE24rnEG4CCilggpyha zzVrsQnPkazmur4IyVprpx4PZ6IA0DWSOlK8niIYXJ0CUb6eii3cXKtpq11QApXZcSdI vxAvHu9dsG/SlT6Z1qcPW5ZKknHBYkfxFTTWy28XL+vWCa2jMu2dyPzpkmr+G7LfNYss pzTJqoqGzXQnhKfogy2XDibwOyJ1QJ0joCvVg24J2aNp1NNSRbUjgd4/wc9Hp16Jlgh+ 2pazfRUx2F5m/mJztm4KM3fHYOXDZpBwZP4NBwcNl92o9JE2ZyaMlsRGNej+yikkh7QM GsPw== X-Gm-Message-State: AOJu0Yy5ZuzwaH1Bdz9ELMkn01eQkstxRywK5zaZsNk1Hc2gmy8A06cb AidY90DBGvFQkxYijFywGDFx873no+KgdakJTMm4O6Qve9LGFIT62VizvdZ1GdiqIA== X-Gm-Gg: AY/fxX4gpGokbtRtSomRMTenzTs9SGsVfAlrLkCC4r65itYVhDVZbYftgvRRkBuyGr1 Yc+55X92xtiJoLy7NxrVz6c2LmX5rSHssWwjwu/o0Mphlv1EDkuuCzQbZy59t91fyqlwJUDYn/K hAWlZdkpzb2/xu7/rYKrmFRZKf0F9zqJ33H1ivLVIvSmfU5NPJCCqMTYkX/VQEtmLLmqxMy37WV eyyZJvUYAJTevqOdhUC1GAf60eQprCaSltsFqJgxXggNi92eL/TSDipsmsD3ty/mHH3HUrGxtCb OLevnx49+HMMz4WLO14tBgs2YKCWKcnit6LcvUOK7VvfZdAlMs7dg/98qSnx2to3gd7yf6qfnCy 8QQxp7ONdvIp2QWWS/M46z+Ww8M04b/X+2hB+vYw+xVFQZG2xkD1D8K2070RWauN+AQ7Phn7YtC uvKg13h5fSKQlWsUfoA92zo4uC6e82gWdmPG6DNO/c9A== X-Received: by 2002:a05:6830:6586:b0:7ce:517b:6010 with SMTP id 46e09a7af769-7cfe00d8620mr2071991a34.8.1768590690697; Fri, 16 Jan 2026 11:11:30 -0800 (PST) Received: from [192.168.0.26] (97-122-114-32.hlrn.qwest.net. [97.122.114.32]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf0db2c1sm2196681a34.5.2026.01.16.11.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:11:30 -0800 (PST) From: Tom Tromey Subject: [PATCH 00/10] More coffread cleanups Date: Fri, 16 Jan 2026 12:11:28 -0700 Message-Id: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGCNamkC/x3MwQrCMAyA4VcZOVtsRzfEVxEPaZduAU1HoiKMv bt1x+/w/xsYKZPBtdtA6cPGVRrCqYO8oMzkeGqG3vejD2F0uZaihJPLD0J5r+ZiKj7FIV+Sj9C 6Vanw93je7s0JjVxSlLz8T1V5Zjk/0V6ksO8/ne4Ie4MAAAA= X-Change-ID: 20260116-coffread-cleanups-4bf0b45c8b04 To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org After Simon removed a huge chunk of coffread.c, I noticed there were more cleanups that could be done. This series is the result. I'm not totally certain how to test this, but I did at least run the resulting gdb on some Windows object files to make sure nothing untoward happens. Signed-off-by: Tom Tromey --- Tom Tromey (10): Constify coffread.c:getsymname Clean up a comment in coffread.c Fix indentation in coffread.c Change coffread.c:pe_file to bool Remove redundant nlist_bfd_global Use symfile_bfd in more places Use coffread_objfile throughout coffread.c Remove coff_symfile_init Remove all globals from coffread.c Change is_import_fixup_symbol to return bool gdb/coffread.c | 327 ++++++++++++++++++++++++++++----------------------------- 1 file changed, 158 insertions(+), 169 deletions(-) --- base-commit: 03375540de733c30feae892db8075eebef946383 change-id: 20260116-coffread-cleanups-4bf0b45c8b04 Best regards, -- Tom Tromey