From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yPwyAfMNa2loMgcAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 23:20:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768623602; bh=LJVFgml4N8iWcQ7+TPGEZgAsjBrkkQmhOdzvbDwcmRI=; h=Date:Subject:From:To:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VnSb/vmmsVcFbTVOBh8OTRqr0g1qMKib9Ah76FV4Gjy3LpguD2kcSWIXA3+xFr1OL iAFV5BBDjLJxE6LCPvzMT4BG3zBiAvJEJR/c411D62k2oUhOZMHlvVO1xTrGAd2INP gcadYHsOx1ZvrDIISCDGwqh3jaTYmR4eZMX+ilBU= Received: by simark.ca (Postfix, from userid 112) id E8A3C1E0DD; Fri, 16 Jan 2026 23:20:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=cDJ9sYmC; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4E8D81E08D for ; Fri, 16 Jan 2026 23:20:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AA9EB4BA23CD for ; Sat, 17 Jan 2026 04:20:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA9EB4BA23CD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=cDJ9sYmC Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8CEA74BA2E1C for ; Sat, 17 Jan 2026 04:19:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CEA74BA2E1C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CEA74BA2E1C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768623576; cv=none; b=agoX6e9C6SjFW9z9gtqcb+erWep1xqMRquQnp5+k67eS7dJN1ygk3zYzZoQ6WVj9fB3qpOSnzyGms2uPjepwc2ZNA1RLx73FRXxQE86hRmwZSsC9KP6YPdCiYeaOs3Xe0s2Yflgk91Pt+xxb2jIDTtgE7k9ilLhEvW7iixpM+uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768623576; c=relaxed/simple; bh=LJVFgml4N8iWcQ7+TPGEZgAsjBrkkQmhOdzvbDwcmRI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=rFrhfa8A4o/LTfUkXzJXY+IRBK5+tap3dnCW+AzFGqP1s9joLGc3kgW1KHysjbBEdahcqwN5QWxui9+oZ95PDs6bQCqsQqWFq5/zp1mcK96OJZWjWbO6mRv1h8Q7M2HVtad0Y0FMmjoJkAi2hemr+1sF9spxB5S1qG99epV0QDU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CEA74BA2E1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768623576; bh=LJVFgml4N8iWcQ7+TPGEZgAsjBrkkQmhOdzvbDwcmRI=; h=Date:Subject:From:To:References:In-Reply-To:From; b=cDJ9sYmCc4F6FPW+I076VQRDzNsraJPhzy1BntQawtHU3fyuqV+00UcdDStj44ADz YBV7Nt6W0OTTTogBxcGW+ud3DqRXibotGeu4reCTRdDKw7LRIdGSJvsHM35OBN8Hk6 gAsP8aFj6QwtD+bKnx6/KFecSxigzhMkc6oicFek= Received: by simark.ca (Postfix) id 1E5321E08D; Fri, 16 Jan 2026 23:19:36 -0500 (EST) Message-ID: <777f675d-4a19-4799-aed5-bfffac5e3ff0@simark.ca> Date: Fri, 16 Jan 2026 23:19:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] Use symfile_bfd in more places From: Simon Marchi To: Tom Tromey , gdb-patches@sourceware.org References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> <20260116-coffread-cleanups-v1-6-4d46090fad69@adacore.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-16 23:09, Simon Marchi wrote: > > > On 2026-01-16 14:11, Tom Tromey wrote: >> Since coffread.c is setting symfile_bfd, it might as well use it >> everywhere. This changes all other BFD references in coffread.c to >> use the global. > > I think you should just remove symfile_bfd too. > > - add a bfd parameter to read_one_sym > - coff_symtab_read can pass objfile->obfd to read_one_sym > - init_stringtab refers to symfile_bfd, but it already receives the > same bfd by parameter, so it can just use the parameter Heh, this should have been in reply to patch 5. Anyway, you can disregard this comment, given that this is all replaced with a reader object at the end. I should really read whole series before commenting on individual patches to know what the end goal is. Simon