From: Simon Marchi <simon.marchi@polymtl.ca>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/linux-fork: simplify one_fork_p
Date: Sun, 19 Jan 2020 16:57:00 -0000 [thread overview]
Message-ID: <770454ed-d5b0-4fce-0bf2-a6952f276959@polymtl.ca> (raw)
In-Reply-To: <CAPTJ0XEmwQ7LRMuAfy8HAj0tNsrui_06RFCP5TKkuTWy4KfCNQ@mail.gmail.com>
On 2020-01-19 11:41 a.m., Christian Biesinger wrote:
> On Sun, Jan 19, 2020 at 11:11 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> Unless I'm missing something, this function is a complicated way of
>> saying "fork_list.size () == 1".
>
> Before C++11, size() wasn't guaranteed to run in constant time, so I
> assume the code was written to handle that. But GDB uses C++11, so
> this change seems fine.
> https://en.cppreference.com/w/cpp/container/list/size
Ahh, good point. Although by the time that change was made, we were already
using C++11. I don't remember if we had a C++ < 11 phase, but if we did it
was very short.
Thanks for looking at it, I'll push it now.
Simon
next prev parent reply other threads:[~2020-01-19 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 16:18 Simon Marchi
2020-01-19 16:53 ` Christian Biesinger via gdb-patches
2020-01-19 16:57 ` Simon Marchi [this message]
2020-01-19 17:01 ` Christian Biesinger via gdb-patches
2020-01-20 15:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=770454ed-d5b0-4fce-0bf2-a6952f276959@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox