From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH] gdb/linux-fork: simplify one_fork_p
Date: Sun, 19 Jan 2020 16:18:00 -0000 [thread overview]
Message-ID: <20200119161058.864-1-simon.marchi@polymtl.ca> (raw)
Unless I'm missing something, this function is a complicated way of
saying "fork_list.size () == 1".
gdb/ChangeLog:
* linux-fork.c (one_fork_p): Simplify.
---
gdb/linux-fork.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
index 284f1985d0dc..357188685d07 100644
--- a/gdb/linux-fork.c
+++ b/gdb/linux-fork.c
@@ -110,8 +110,7 @@ find_last_fork (void)
static bool
one_fork_p ()
{
- return (!fork_list.empty ()
- && &fork_list.front () == &fork_list.back ());
+ return fork_list.size () == 1;
}
/* Add a new fork to the internal fork list. */
--
2.24.1
next reply other threads:[~2020-01-19 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 16:18 Simon Marchi [this message]
2020-01-19 16:53 ` Christian Biesinger via gdb-patches
2020-01-19 16:57 ` Simon Marchi
2020-01-19 17:01 ` Christian Biesinger via gdb-patches
2020-01-20 15:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119161058.864-1-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox