Re: [PATCH] gdb/linux-fork: simplify one_fork_p

["Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>]

On Sun, Jan 19, 2020 at 11:53 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2020-01-19 11:41 a.m., Christian Biesinger wrote:
> > On Sun, Jan 19, 2020 at 11:11 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
> >>
> >> Unless I'm missing something, this function is a complicated way of
> >> saying "fork_list.size () == 1".
> >
> > Before C++11, size() wasn't guaranteed to run in constant time, so I
> > assume the code was written to handle that. But GDB uses C++11, so
> > this change seems fine.
> > https://en.cppreference.com/w/cpp/container/list/size
>
> Ahh, good point.  Although by the time that change was made, we were already
> using C++11.  I don't remember if we had a C++ < 11 phase, but if we did it
> was very short.
>
> Thanks for looking at it, I'll push it now.

Ah. it's also possible that whoever wrote the code just assumed that
size() would run in linear time, of course.

Christian