From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50562 invoked by alias); 19 Jan 2020 16:53:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50554 invoked by uid 89); 19 Jan 2020 16:53:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HDKIM-Filter:v2.11.0, HDKIM-Filter:OpenDKIM, HDKIM-Filter:Filter, UD:ca X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Jan 2020 16:53:28 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 00JGrJd9027617 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Jan 2020 11:53:24 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 00JGrJd9027617 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1579452805; bh=+MSBtFpuaPwrbkUnvm/YvSsOY9AJEEywipXIighZhh8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TN5VRfoiS79gcWxlLIc33DZBg4l2lME+cqyCEzKAstMz3Zt5zMSJm7n9Ti1NI4+L0 KcwALEHFK5NuAgQkVCvkw+blHCSF5YB/nm/OYYHabcE72ggdmo5obqE+0cN6WiIlob xRbE8fyzSUm1jMpxxDvhRz1TgnNQcSkgXAmPmmZA= Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C2C561E47D; Sun, 19 Jan 2020 11:53:19 -0500 (EST) Subject: Re: [PATCH] gdb/linux-fork: simplify one_fork_p To: Christian Biesinger Cc: gdb-patches References: <20200119161058.864-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <770454ed-d5b0-4fce-0bf2-a6952f276959@polymtl.ca> Date: Sun, 19 Jan 2020 16:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00587.txt.bz2 On 2020-01-19 11:41 a.m., Christian Biesinger wrote: > On Sun, Jan 19, 2020 at 11:11 AM Simon Marchi wrote: >> >> Unless I'm missing something, this function is a complicated way of >> saying "fork_list.size () == 1". > > Before C++11, size() wasn't guaranteed to run in constant time, so I > assume the code was written to handle that. But GDB uses C++11, so > this change seems fine. > https://en.cppreference.com/w/cpp/container/list/size Ahh, good point. Although by the time that change was made, we were already using C++11. I don't remember if we had a C++ < 11 phase, but if we did it was very short. Thanks for looking at it, I'll push it now. Simon