Re: [PATCH v3 02/44] bfd: add intelgt target to BFD

[Simon Marchi <simark@simark.ca>]

On 8/1/25 5:37 AM, Tankut Baris Aktemur wrote:
> From: Natalia Saiapova <natalia.saiapova@intel.com>
> 
> Add description of IntelGT target to BFD.  Describe its relocation
> types.
> 
> To: <binutils@sourceware.org>

Not a binutils maintainer, but I gave it a high level look.

> @@ -705,12 +706,12 @@ case "${targ}" in
>      ;;
>    x86_64-*-linux-*)
>      targ_defvec=x86_64_elf64_vec
> -    targ_selvecs="i386_elf32_vec iamcu_elf32_vec x86_64_elf32_vec i386_pei_vec x86_64_pe_vec x86_64_pei_vec"
> +    targ_selvecs="i386_elf32_vec iamcu_elf32_vec x86_64_elf32_vec i386_pei_vec x86_64_pe_vec x86_64_pei_vec intelgt_elf64_vec"
>      want64=true
>      ;;
>    x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin)
>      targ_defvec=x86_64_pe_vec
> -    targ_selvecs="x86_64_pe_vec x86_64_pei_vec x86_64_pe_big_vec x86_64_elf64_vec i386_pe_vec i386_pei_vec i386_elf32_vec iamcu_elf32_vec pdb_vec"
> +    targ_selvecs="x86_64_pe_vec x86_64_pei_vec x86_64_pe_big_vec x86_64_elf64_vec i386_pe_vec i386_pei_vec i386_elf32_vec iamcu_elf32_vec pdb_vec intelgt_elf64_vec intelgt_legacy_elf64_vec"

Does it makes sense to automatically enable intelgt support alongside
x86-64?  Are they logically related, or completely different
architectures?  Since it's possible to enale intelgt specifically (the
hunk below in the same file), I'm not sure why it should piggy back on
x86-64 here.

> diff --git a/include/elf/intelgt.h b/include/elf/intelgt.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..cdade55ea4864aa23cd6e8b2a079e6f5e2ff91fb
> --- /dev/null
> +++ b/include/elf/intelgt.h
> @@ -0,0 +1,39 @@
> +/* Copyright (C) 2022-2025 Free Software Foundation, Inc.
> +
> +   This file is part of BFD, the Binary File Descriptor library.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
> +   MA 02110-1301, USA.  */
> +
> +/* This file holds definitions specific to the IntelGT ABI.  */
> +
> +#ifndef __INTELGT_H_
> +#define __INTELGT_H_

Based on the other files in this directory, the include guard should be
"_ELF_INTELGT_H".

Simon