From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OORPKSyPOGn5eCkAWB0awg (envelope-from ) for ; Tue, 09 Dec 2025 16:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765314348; bh=O7gtr4RVuabXsbx6TgFf4Ro9rS3mi68zrEbu+5ehgYI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ihnV+8ZxyNYiwJlIdpJqohjMlnv4RURGpRInOJ/8McuxW/rhBoeije3AuB5p7A+XO QMLTqXwsQ1j+HM5SLNkOc2EYZ5viWis6lHNekaVfYJmcpWQ1w+ECHN9mg9y5KVaSrx nXLvE3m76/MwPhWZdd8l7t8B9vfMRvF8girie0ts= Received: by simark.ca (Postfix, from userid 112) id 9956B1E08D; Tue, 09 Dec 2025 16:05:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lb+Ebd8t; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA98F1E08D for ; Tue, 09 Dec 2025 16:05:46 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7EB2B4BA2E2A for ; Tue, 9 Dec 2025 21:05:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7EB2B4BA2E2A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lb+Ebd8t Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DED884BA2E1D; Tue, 9 Dec 2025 21:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DED884BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DED884BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765314313; cv=none; b=I7ejI+IBLrDAO7XafXZDqauUkiEbKIKNu+kZNDbfvixxI2CneedfdXBPQFdv2zlP1AQlRok8TYP3Ki++KHNd4ZPsWWxPn7BYDs+ILn1YnhME3zZ19SkJhqIO/MlzULPUi1h3dN9Z6LgcGamIF8yn2V7vl2ZvJHuvCM80PXMNdFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765314313; c=relaxed/simple; bh=O7gtr4RVuabXsbx6TgFf4Ro9rS3mi68zrEbu+5ehgYI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=P3BZa1Geaw7JujKdS8iQXBw93m720zr8mQD+2SXG5sb7ztCJ8rhUp6w4YF3arWtsHMQZlonM8swWw4NhNB8J2D0JWmpV5925MAxFwaVWb87n0vxgdVPc2MbW7vUbQauV+IlbPj9POK9TI7aO6vI98AyouAAEGz7nBX7Auk5Q9o8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DED884BA2E1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765314312; bh=O7gtr4RVuabXsbx6TgFf4Ro9rS3mi68zrEbu+5ehgYI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=lb+Ebd8tb+yOgUAvpg+wBACb9gyoBXyqIgow6gxSWh2moXfUjTebG3E6LpR7INk3c Tvgy0taSORHunGuF7y+BeX9ftonl3GbW5MgGvo+5h0IuBlnYVNMGMfAga5i9L8XTeA DTK1MIj7aVHuAtut53phIsTajJp47Lcm4/+HWXQs= Received: by simark.ca (Postfix) id 5E5671E08D; Tue, 09 Dec 2025 16:05:12 -0500 (EST) Message-ID: <76fabf83-3abd-4f5e-b9fb-40cd1565b970@simark.ca> Date: Tue, 9 Dec 2025 16:05:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/44] bfd: add intelgt target to BFD To: Tankut Baris Aktemur , gdb-patches@sourceware.org, Markus Metzger , binutils@sourceware.org References: <20250801-upstream-intelgt-mvp-v3-0-59ce0f87075b@intel.com> <20250801-upstream-intelgt-mvp-v3-2-59ce0f87075b@intel.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250801-upstream-intelgt-mvp-v3-2-59ce0f87075b@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/1/25 5:37 AM, Tankut Baris Aktemur wrote: > From: Natalia Saiapova > > Add description of IntelGT target to BFD. Describe its relocation > types. > > To: Not a binutils maintainer, but I gave it a high level look. > @@ -705,12 +706,12 @@ case "${targ}" in > ;; > x86_64-*-linux-*) > targ_defvec=x86_64_elf64_vec > - targ_selvecs="i386_elf32_vec iamcu_elf32_vec x86_64_elf32_vec i386_pei_vec x86_64_pe_vec x86_64_pei_vec" > + targ_selvecs="i386_elf32_vec iamcu_elf32_vec x86_64_elf32_vec i386_pei_vec x86_64_pe_vec x86_64_pei_vec intelgt_elf64_vec" > want64=true > ;; > x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin) > targ_defvec=x86_64_pe_vec > - targ_selvecs="x86_64_pe_vec x86_64_pei_vec x86_64_pe_big_vec x86_64_elf64_vec i386_pe_vec i386_pei_vec i386_elf32_vec iamcu_elf32_vec pdb_vec" > + targ_selvecs="x86_64_pe_vec x86_64_pei_vec x86_64_pe_big_vec x86_64_elf64_vec i386_pe_vec i386_pei_vec i386_elf32_vec iamcu_elf32_vec pdb_vec intelgt_elf64_vec intelgt_legacy_elf64_vec" Does it makes sense to automatically enable intelgt support alongside x86-64? Are they logically related, or completely different architectures? Since it's possible to enale intelgt specifically (the hunk below in the same file), I'm not sure why it should piggy back on x86-64 here. > diff --git a/include/elf/intelgt.h b/include/elf/intelgt.h > new file mode 100644 > index 0000000000000000000000000000000000000000..cdade55ea4864aa23cd6e8b2a079e6f5e2ff91fb > --- /dev/null > +++ b/include/elf/intelgt.h > @@ -0,0 +1,39 @@ > +/* Copyright (C) 2022-2025 Free Software Foundation, Inc. > + > + This file is part of BFD, the Binary File Descriptor library. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program; if not, write to the Free Software > + Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, > + MA 02110-1301, USA. */ > + > +/* This file holds definitions specific to the IntelGT ABI. */ > + > +#ifndef __INTELGT_H_ > +#define __INTELGT_H_ Based on the other files in this directory, the include guard should be "_ELF_INTELGT_H". Simon