From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp
Date: Tue, 12 May 2020 10:14:53 -0400 [thread overview]
Message-ID: <73a5e27b-a709-8861-1f88-a07a0a2a71f9@polymtl.ca> (raw)
In-Reply-To: <20200512130002.GA3290@delia>
On 2020-05-12 9:00 a.m., Tom de Vries wrote:
> Hi,
>
> When running test-case gdb.base/jit-elf.exp with target board
> cc-with-gdb-index, we get:
> ...
> spawn -ignore SIGHUP gdb/contrib/cc-with-tweaks.sh -i gcc \
> -fno-stack-protector src/gdb/testsuite/gdb.base/jit-elf-main.c \
> -fdiagnostics-color=never -DATTACH=1 -DLOAD_ADDRESS=0x7000000 \
> -DLOAD_INCREMENT=0x1000000 -g -lm \
> -o outputs/gdb.base/jit-elf/jit-elf-main"-attach"^M
> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
> No such file or directory.^M
> output is:
> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
> No such file or directory.^M
>
> gdb compile failed, outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
> No such file or directory.
> UNTESTED: gdb.base/jit-elf.exp: failed to compile jit-elf-main"-attach"
> ...
>
> The problem is a string concat in jit-elf.exp:
> ...
> ${main_binfile}"-attach"
> ...
> which is intended to generate string 'jit-elf-main-attach' but instead
> generates string 'jit-elf-main"-attach"'.
>
> Fix this by using "${main_binfile}-attach" instead.
>
> Tested on x86_64-linux.
>
> Committed to trunk.
>
> Thanks,
> - Tom
Thanks for the fixes to the JIT tests Tom. I did not test with non-default
boards, I'll try to do it more diligently in the future.
Simon
next prev parent reply other threads:[~2020-05-12 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:00 Tom de Vries
2020-05-12 14:14 ` Simon Marchi [this message]
2020-05-12 14:37 ` Strasuns, Mihails
2020-05-13 8:52 ` Tom de Vries
2020-05-13 13:45 ` Simon Marchi
2020-05-26 8:49 ` How to run multiple target boards Tom de Vries
2020-05-26 10:39 ` Pedro Alves
2020-05-26 10:56 ` Tom de Vries
2020-05-26 20:38 ` Simon Marchi
2020-05-13 8:44 ` [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a5e27b-a709-8861-1f88-a07a0a2a71f9@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox