Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp

[Tom de Vries <tdevries@suse.de>]

On 12-05-2020 16:14, Simon Marchi wrote:
> On 2020-05-12 9:00 a.m., Tom de Vries wrote:
>> Hi,
>>
>> When running test-case gdb.base/jit-elf.exp with target board
>> cc-with-gdb-index, we get:
>> ...
>> spawn -ignore SIGHUP gdb/contrib/cc-with-tweaks.sh -i gcc \
>>   -fno-stack-protector src/gdb/testsuite/gdb.base/jit-elf-main.c \
>>   -fdiagnostics-color=never -DATTACH=1 -DLOAD_ADDRESS=0x7000000 \
>>   -DLOAD_INCREMENT=0x1000000 -g -lm \
>>   -o outputs/gdb.base/jit-elf/jit-elf-main"-attach"^M
>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>   No such file or directory.^M
>> output is:
>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>   No such file or directory.^M
>>
>> gdb compile failed, outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>   No such file or directory.
>> UNTESTED: gdb.base/jit-elf.exp: failed to compile jit-elf-main"-attach"
>> ...
>>
>> The problem is a string concat in jit-elf.exp:
>> ...
>>   ${main_binfile}"-attach"
>> ...
>> which is intended to generate string 'jit-elf-main-attach' but instead
>> generates string 'jit-elf-main"-attach"'.
>>
>> Fix this by using "${main_binfile}-attach" instead.
>>
>> Tested on x86_64-linux.
>>
>> Committed to trunk.
>>
>> Thanks,
>> - Tom
> 
> Thanks for the fixes to the JIT tests Tom.  I did not test with non-default
> boards, I'll try to do it more diligently in the future.

I usually only test with the symtabs-related boards if I do a
symtab-related fix, so I don't think I would have found this either
pre-commit :)

[ And this could have been found by the buildbot, were it not two weeks
behind :( . I realize I'm guilty there a bit for doing lots of small
commits, which doesn't help. ]

Thanks,
- Tom