Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp

[Tom de Vries <tdevries@suse.de>]

Hi,

I don't know if such a generic list exists.  I'd say what makes sense
depends on the patch.

For symtab-related patches, use readnow, cc-with-gdb-index,
cc-with-debug-names.

If the test contains nonstandard handling of inferiors, try some
gdbserver boards (I'm not sure which).

If the test contains explicit file handling, try some of the remote
boards (I'm not sure which).

Thanks,
- Tom

On 12-05-2020 16:37, Strasuns, Mihails wrote:
> On that topic - what is the recommended set of boards to check locally for a generic gdb patchset?
> 
> Mihails
> 
>> -----Original Message-----
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Sent: Tuesday, May 12, 2020 4:15 PM
>> To: Tom de Vries <tdevries@suse.de>; gdb-patches@sourceware.org
>> Cc: Strasuns, Mihails <mihails.strasuns@intel.com>
>> Subject: Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-
>> elf.exp
>>
>> On 2020-05-12 9:00 a.m., Tom de Vries wrote:
>>> Hi,
>>>
>>> When running test-case gdb.base/jit-elf.exp with target board
>>> cc-with-gdb-index, we get:
>>> ...
>>> spawn -ignore SIGHUP gdb/contrib/cc-with-tweaks.sh -i gcc \
>>>   -fno-stack-protector src/gdb/testsuite/gdb.base/jit-elf-main.c \
>>>   -fdiagnostics-color=never -DATTACH=1 -DLOAD_ADDRESS=0x7000000 \
>>>   -DLOAD_INCREMENT=0x1000000 -g -lm \
>>>   -o outputs/gdb.base/jit-elf/jit-elf-main"-attach"^M
>>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>>   No such file or directory.^M
>>> output is:
>>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>>   No such file or directory.^M
>>>
>>> gdb compile failed, outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \
>>>   No such file or directory.
>>> UNTESTED: gdb.base/jit-elf.exp: failed to compile jit-elf-main"-attach"
>>> ...
>>>
>>> The problem is a string concat in jit-elf.exp:
>>> ...
>>>   ${main_binfile}"-attach"
>>> ...
>>> which is intended to generate string 'jit-elf-main-attach' but instead
>>> generates string 'jit-elf-main"-attach"'.
>>>
>>> Fix this by using "${main_binfile}-attach" instead.
>>>
>>> Tested on x86_64-linux.
>>>
>>> Committed to trunk.
>>>
>>> Thanks,
>>> - Tom
>>
>> Thanks for the fixes to the JIT tests Tom.  I did not test with non-default
>> boards, I'll try to do it more diligently in the future.
>>
>> Simon
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Gary Kershaw
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>