From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 05651386F430 for ; Wed, 13 May 2020 08:52:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 05651386F430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C4E51AC5F; Wed, 13 May 2020 08:52:32 +0000 (UTC) Subject: Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp To: "Strasuns, Mihails" , Simon Marchi , "gdb-patches@sourceware.org" References: <20200512130002.GA3290@delia> <73a5e27b-a709-8861-1f88-a07a0a2a71f9@polymtl.ca> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <256a0db7-98c2-7769-7991-981f59106ee4@suse.de> Date: Wed, 13 May 2020 10:52:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 08:52:32 -0000 Hi, I don't know if such a generic list exists. I'd say what makes sense depends on the patch. For symtab-related patches, use readnow, cc-with-gdb-index, cc-with-debug-names. If the test contains nonstandard handling of inferiors, try some gdbserver boards (I'm not sure which). If the test contains explicit file handling, try some of the remote boards (I'm not sure which). Thanks, - Tom On 12-05-2020 16:37, Strasuns, Mihails wrote: > On that topic - what is the recommended set of boards to check locally for a generic gdb patchset? > > Mihails > >> -----Original Message----- >> From: Simon Marchi >> Sent: Tuesday, May 12, 2020 4:15 PM >> To: Tom de Vries ; gdb-patches@sourceware.org >> Cc: Strasuns, Mihails >> Subject: Re: [committed][gdb/testsuite] Fix incorrect string concat in jit- >> elf.exp >> >> On 2020-05-12 9:00 a.m., Tom de Vries wrote: >>> Hi, >>> >>> When running test-case gdb.base/jit-elf.exp with target board >>> cc-with-gdb-index, we get: >>> ... >>> spawn -ignore SIGHUP gdb/contrib/cc-with-tweaks.sh -i gcc \ >>> -fno-stack-protector src/gdb/testsuite/gdb.base/jit-elf-main.c \ >>> -fdiagnostics-color=never -DATTACH=1 -DLOAD_ADDRESS=0x7000000 \ >>> -DLOAD_INCREMENT=0x1000000 -g -lm \ >>> -o outputs/gdb.base/jit-elf/jit-elf-main"-attach"^M >>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ >>> No such file or directory.^M >>> output is: >>> outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ >>> No such file or directory.^M >>> >>> gdb compile failed, outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ >>> No such file or directory. >>> UNTESTED: gdb.base/jit-elf.exp: failed to compile jit-elf-main"-attach" >>> ... >>> >>> The problem is a string concat in jit-elf.exp: >>> ... >>> ${main_binfile}"-attach" >>> ... >>> which is intended to generate string 'jit-elf-main-attach' but instead >>> generates string 'jit-elf-main"-attach"'. >>> >>> Fix this by using "${main_binfile}-attach" instead. >>> >>> Tested on x86_64-linux. >>> >>> Committed to trunk. >>> >>> Thanks, >>> - Tom >> >> Thanks for the fixes to the JIT tests Tom. I did not test with non-default >> boards, I'll try to do it more diligently in the future. >> >> Simon > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Gary Kershaw > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >