From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0DBFD3939C07 for ; Tue, 12 May 2020 14:15:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DBFD3939C07 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 04CEErd7023374 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 May 2020 10:14:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 04CEErd7023374 Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 84FF01E79B; Tue, 12 May 2020 10:14:53 -0400 (EDT) Subject: Re: [committed][gdb/testsuite] Fix incorrect string concat in jit-elf.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20200512130002.GA3290@delia> From: Simon Marchi Message-ID: <73a5e27b-a709-8861-1f88-a07a0a2a71f9@polymtl.ca> Date: Tue, 12 May 2020 10:14:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200512130002.GA3290@delia> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 12 May 2020 14:14:54 +0000 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 14:15:08 -0000 On 2020-05-12 9:00 a.m., Tom de Vries wrote: > Hi, > > When running test-case gdb.base/jit-elf.exp with target board > cc-with-gdb-index, we get: > ... > spawn -ignore SIGHUP gdb/contrib/cc-with-tweaks.sh -i gcc \ > -fno-stack-protector src/gdb/testsuite/gdb.base/jit-elf-main.c \ > -fdiagnostics-color=never -DATTACH=1 -DLOAD_ADDRESS=0x7000000 \ > -DLOAD_INCREMENT=0x1000000 -g -lm \ > -o outputs/gdb.base/jit-elf/jit-elf-main"-attach"^M > outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ > No such file or directory.^M > output is: > outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ > No such file or directory.^M > > gdb compile failed, outputs/gdb.base/jit-elf/.tmp/jit-elf-main-attach: \ > No such file or directory. > UNTESTED: gdb.base/jit-elf.exp: failed to compile jit-elf-main"-attach" > ... > > The problem is a string concat in jit-elf.exp: > ... > ${main_binfile}"-attach" > ... > which is intended to generate string 'jit-elf-main-attach' but instead > generates string 'jit-elf-main"-attach"'. > > Fix this by using "${main_binfile}-attach" instead. > > Tested on x86_64-linux. > > Committed to trunk. > > Thanks, > - Tom Thanks for the fixes to the JIT tests Tom. I did not test with non-default boards, I'll try to do it more diligently in the future. Simon