Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: [RFA] PTRACE_ARG3_TYPE cleanup
@ 2004-09-08  7:05 M.M. Kettenis
  0 siblings, 0 replies; 4+ messages in thread
From: M.M. Kettenis @ 2004-09-08  7:05 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

Joel Brobecker <brobecker@gnat.com> wrote:

> > Unfortunately not.  The HP-UX changes aren't correct, because of the
> > pretend-that-ttrace-is-ptrace maddness in the HP-UX-specific files.  I
> > haven't found the time to sort that out properly yet :-(.
> >
> > The OSF/1 and AIX changes are OK though.
>
> ARgh! Thanks for catching this!
>

Just FYI, I'm performing major surgery on the HP-UX native code, such that I get it back in line with the other code.  That's going to take some time though.

Mark



^ permalink raw reply	[flat|nested] 4+ messages in thread
* [RFA] PTRACE_ARG3_TYPE cleanup
@ 2004-09-01 20:30 Joel Brobecker
  2004-09-03 15:07 ` Mark Kettenis
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2004-09-01 20:30 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Removing some #defines that are no longer necessary, thanks to
inferior.h and configure:

        #ifndef PTRACE_ARG3_TYPE
        #define PTRACE_ARG3_TYPE PTRACE_TYPE_ARG3
        #endif

(PTRACE_TYPE_ARG3 is set to the right type by configure).

2004-09-01  Joel Brobecker  <brobecker@gnat.com>

        * config/alpha/nm-osf.h (PTRACE_ARG3_TYPE): Remove define.
        * config/pa/nm-hppah.h (PTRACE_ARG3_TYPE): Likewise.
        * config/powerpc/nm-aix.h (PTRACE_ARG3_TYPE): Likewise.

Tested on alpha-tru64 5.1a, pa-hpux 11.00, and ppc-aix 5.1.
OK to apply?

I think all other instances of this macro can go as well, but
I wouldn't be able to test these changes, so I left them. Maybe we
should just remove them as an "obvious" change.

-- 
Joel

[-- Attachment #2: ARG3.diff --]
[-- Type: text/plain, Size: 2169 bytes --]

Index: alpha/nm-osf.h
===================================================================
RCS file: /cvs/src/src/gdb/config/alpha/nm-osf.h,v
retrieving revision 1.7
diff -u -p -r1.7 nm-osf.h
--- alpha/nm-osf.h	16 Feb 2004 23:59:43 -0000	1.7
+++ alpha/nm-osf.h	1 Sep 2004 17:55:58 -0000
@@ -29,10 +29,6 @@
 
 #define U_REGS_OFFSET 0
 
-/* FIXME: Shouldn't the default definition in inferior.h be int* ? */
-
-#define PTRACE_ARG3_TYPE int*
-
 /* ptrace transfers longs, the ptrace man page is lying.  */
 
 #define PTRACE_XFER_TYPE long
Index: pa/nm-hppah.h
===================================================================
RCS file: /cvs/src/src/gdb/config/pa/nm-hppah.h,v
retrieving revision 1.21
diff -u -p -r1.21 nm-hppah.h
--- pa/nm-hppah.h	11 Aug 2004 21:51:28 -0000	1.21
+++ pa/nm-hppah.h	1 Sep 2004 17:56:02 -0000
@@ -29,18 +29,6 @@ struct target_ops;
 #define REGISTER_U_ADDR(addr, blockend, regno)				\
 { addr = (int)(blockend) + DEPRECATED_REGISTER_BYTE (regno);}
 
-/* This isn't really correct, because ptrace is actually a 32-bit
-   interface.  However, the modern HP-UX targets all really use
-   ttrace, which is a 64-bit interface --- a debugger running in
-   either 32- or 64-bit mode can debug a 64-bit process.  BUT, the
-   code doesn't use ttrace directly --- it calls call_ptrace instead,
-   which is supposed to be drop-in substitute for ptrace.  In other
-   words, they access a 64-bit system call (ttrace) through a
-   compatibility layer which is allegedly a 32-bit interface.
-
-   So I don't feel the least bit guilty about this.  */
-#define PTRACE_ARG3_TYPE CORE_ADDR
-
 /* We need to figure out where the text region is so that we use the
    appropriate ptrace operator to manipulate text.  Simply
    reading/writing user space will crap out HPUX.  */
Index: powerpc/nm-aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/nm-aix.h,v
retrieving revision 1.2
diff -u -p -r1.2 nm-aix.h
--- powerpc/nm-aix.h	6 Mar 2001 08:21:34 -0000	1.2
+++ powerpc/nm-aix.h	1 Sep 2004 17:56:02 -0000
@@ -20,4 +20,3 @@
 
 #include "rs6000/nm-rs6000.h"
 
-#define PTRACE_ARG3_TYPE int*

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-08  7:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-08  7:05 [RFA] PTRACE_ARG3_TYPE cleanup M.M. Kettenis
  -- strict thread matches above, loose matches on Subject: below --
2004-09-01 20:30 Joel Brobecker
2004-09-03 15:07 ` Mark Kettenis
2004-09-04 23:47   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox