From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15086 invoked by alias); 4 Sep 2004 23:47:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15078 invoked from network); 4 Sep 2004 23:47:51 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 4 Sep 2004 23:47:51 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 5ABC947D92; Sat, 4 Sep 2004 16:47:51 -0700 (PDT) Date: Sat, 04 Sep 2004 23:47:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] PTRACE_ARG3_TYPE cleanup Message-ID: <20040904234751.GA1216@gnat.com> References: <20040901203048.GF978@gnat.com> <200409031507.i83F7O49007593@juw15.nfra.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <200409031507.i83F7O49007593@juw15.nfra.nl> User-Agent: Mutt/1.4i X-SW-Source: 2004-09/txt/msg00084.txt.bz2 --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 512 > Unfortunately not. The HP-UX changes aren't correct, because of the > pretend-that-ttrace-is-ptrace maddness in the HP-UX-specific files. I > haven't found the time to sort that out properly yet :-(. > > The OSF/1 and AIX changes are OK though. ARgh! Thanks for catching this! Here is what I ended up committing: 2004-09-04 Joel Brobecker * config/alpha/nm-osf.h (PTRACE_ARG3_TYPE): Remove define. * config/powerpc/nm-aix.h (PTRACE_ARG3_TYPE): Likewise. -- Joel --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ARG3.diff" Content-length: 912 Index: alpha/nm-osf.h =================================================================== RCS file: /cvs/src/src/gdb/config/alpha/nm-osf.h,v retrieving revision 1.7 diff -u -p -r1.7 nm-osf.h --- alpha/nm-osf.h 16 Feb 2004 23:59:43 -0000 1.7 +++ alpha/nm-osf.h 1 Sep 2004 17:55:58 -0000 @@ -29,10 +29,6 @@ #define U_REGS_OFFSET 0 -/* FIXME: Shouldn't the default definition in inferior.h be int* ? */ - -#define PTRACE_ARG3_TYPE int* - /* ptrace transfers longs, the ptrace man page is lying. */ #define PTRACE_XFER_TYPE long Index: powerpc/nm-aix.h =================================================================== RCS file: /cvs/src/src/gdb/config/powerpc/nm-aix.h,v retrieving revision 1.2 diff -u -p -r1.2 nm-aix.h --- powerpc/nm-aix.h 6 Mar 2001 08:21:34 -0000 1.2 +++ powerpc/nm-aix.h 1 Sep 2004 17:56:02 -0000 @@ -20,4 +20,3 @@ #include "rs6000/nm-rs6000.h" -#define PTRACE_ARG3_TYPE int* --VbJkn9YxBvnuCH5J--