From: Joel Brobecker <brobecker@gnat.com>
To: Mark Kettenis <kettenis@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] PTRACE_ARG3_TYPE cleanup
Date: Sat, 04 Sep 2004 23:47:00 -0000 [thread overview]
Message-ID: <20040904234751.GA1216@gnat.com> (raw)
In-Reply-To: <200409031507.i83F7O49007593@juw15.nfra.nl>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
> Unfortunately not. The HP-UX changes aren't correct, because of the
> pretend-that-ttrace-is-ptrace maddness in the HP-UX-specific files. I
> haven't found the time to sort that out properly yet :-(.
>
> The OSF/1 and AIX changes are OK though.
ARgh! Thanks for catching this!
Here is what I ended up committing:
2004-09-04 Joel Brobecker <brobecker@gnat.com>
* config/alpha/nm-osf.h (PTRACE_ARG3_TYPE): Remove define.
* config/powerpc/nm-aix.h (PTRACE_ARG3_TYPE): Likewise.
--
Joel
[-- Attachment #2: ARG3.diff --]
[-- Type: text/plain, Size: 912 bytes --]
Index: alpha/nm-osf.h
===================================================================
RCS file: /cvs/src/src/gdb/config/alpha/nm-osf.h,v
retrieving revision 1.7
diff -u -p -r1.7 nm-osf.h
--- alpha/nm-osf.h 16 Feb 2004 23:59:43 -0000 1.7
+++ alpha/nm-osf.h 1 Sep 2004 17:55:58 -0000
@@ -29,10 +29,6 @@
#define U_REGS_OFFSET 0
-/* FIXME: Shouldn't the default definition in inferior.h be int* ? */
-
-#define PTRACE_ARG3_TYPE int*
-
/* ptrace transfers longs, the ptrace man page is lying. */
#define PTRACE_XFER_TYPE long
Index: powerpc/nm-aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/nm-aix.h,v
retrieving revision 1.2
diff -u -p -r1.2 nm-aix.h
--- powerpc/nm-aix.h 6 Mar 2001 08:21:34 -0000 1.2
+++ powerpc/nm-aix.h 1 Sep 2004 17:56:02 -0000
@@ -20,4 +20,3 @@
#include "rs6000/nm-rs6000.h"
-#define PTRACE_ARG3_TYPE int*
next prev parent reply other threads:[~2004-09-04 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 20:30 Joel Brobecker
2004-09-03 15:07 ` Mark Kettenis
2004-09-04 23:47 ` Joel Brobecker [this message]
2004-09-08 7:05 M.M. Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904234751.GA1216@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox