From: Patrick Monnerat via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Replace deprecated_target_wait_hook by an observer
Date: Mon, 23 Aug 2021 20:01:49 +0200 [thread overview]
Message-ID: <723fdf83-3fb9-4c77-09c9-f33c1faa98a7@monnerat.net> (raw)
In-Reply-To: <5697ed83-dd71-c977-9f04-cffa75751c23@polymtl.ca>
On 8/23/21 7:48 PM, Simon Marchi wrote:
>> For more details, see Insight commit https://sourceware.org/git/?p=insight.git;a=commit;h=16042bf
> Thanks, that clarifies why you need it to be called both before and
> after.
>
> I think it would be good to add some comment above where the obsserver
> is notified to say that this is used by Insight, otherwise someone might
> be tempted to remove it, as it is unused in the GDB project itself.
>
> I suggest leaving the review up for a week, if nobody has objections,
> I'll merge your patch (and I can add the comment myself).
That's fine for me, thanks.
Patrick
next prev parent reply other threads:[~2021-08-23 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 16:42 Patrick Monnerat via Gdb-patches
2021-08-23 16:26 ` Simon Marchi via Gdb-patches
2021-08-23 17:36 ` Patrick Monnerat via Gdb-patches
2021-08-23 17:48 ` Simon Marchi via Gdb-patches
2021-08-23 18:01 ` Patrick Monnerat via Gdb-patches [this message]
2021-08-24 16:14 ` Andrew Burgess
2021-08-25 13:30 ` Patrick Monnerat via Gdb-patches
2021-08-25 16:19 ` Andrew Burgess
2021-08-26 2:41 ` Simon Marchi via Gdb-patches
2021-08-26 10:53 ` Patrick Monnerat via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723fdf83-3fb9-4c77-09c9-f33c1faa98a7@monnerat.net \
--to=gdb-patches@sourceware.org \
--cc=patrick@monnerat.net \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox