Re: [PATCH] Replace deprecated_target_wait_hook by an observer

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-08-22 12:42 p.m., Patrick Monnerat via Gdb-patches wrote:
> Commit b60cea7 (Make target_wait options use enum flags) broke
> deprecated_target_wait_hook usage: there's a commit comment telling
> this hook has not been converted.
> 
> Rather than trying to mend it, this patch replaces the hook by a
> target_wait observer:
> 
> waiting_for_target (bool entering, ptid_t ptid)
> 
> Upon target_wait entry, it is notified with entering=TRUE and ptid passed
> to target_wait. Upon exit, it is notified again with entering=FALSE and
> ptid = event ptid returned by target_wait.
> 
> This change benefits to Insight (out-of-tree): there's no real use of the
> late hook in gdb itself.

Hi,

If that works for Insight (I presume it does, since you are sending this
patch), then this is a welcome change.  Can you show to the
corresponding change in Insight?  I'm curious to see how Insight uses
this.

But otherwise, the change in gdb looks good to me.

Simon