Re: [PATCH] Replace deprecated_target_wait_hook by an observer

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-08-23 1:36 p.m., Patrick Monnerat wrote:
> 
> On 8/23/21 6:26 PM, Simon Marchi wrote:
>> Can you show to the
>> corresponding change in Insight?  I'm curious to see how Insight uses
>> this.
>>
> Hi Simon,
> 
> Sure! Here is the important part of the Insight diff:
> 
> -----
> 
> --- a/gdbtk/generic/gdbtk-hooks.c
> +++ b/gdbtk/generic/gdbtk-hooks.c
> 
> @@ -685,16 +685,19 @@ gdbtk_post_add_symbol (void)
>  /* This hook function is called whenever we want to wait for the
>     target.  */
> 
> -static ptid_t
> -gdbtk_wait (ptid_t ptid, struct target_waitstatus *ourstatus, void *options)
> +static void
> +gdbtk_waiting_for_target (bool enter, ptid_t ptid)
>  {
> -  gdbtk_force_detach = 0;
> -  gdbtk_start_timer ();
> -  ptid = target_wait (ptid, ourstatus, *(target_wait_flags *) options);
> -  gdbtk_stop_timer ();
> -  gdbtk_ptid = ptid;
> -
> -  return ptid;
> +  if (enter)
> +    {
> +      gdbtk_force_detach = 0;
> +      gdbtk_start_timer ();
> +    }
> +  else
> +    {
> +      gdbtk_stop_timer ();
> +      gdbtk_ptid = ptid;
> +    }
>  }
> 
>  /*
> -----
> 
> For more details, see Insight commit https://sourceware.org/git/?p=insight.git;a=commit;h=16042bf

Thanks, that clarifies why you need it to be called both before and
after.

I think it would be good to add some comment above where the obsserver
is notified to say that this is used by Insight, otherwise someone might
be tempted to remove it, as it is unused in the GDB project itself.

I suggest leaving the review up for a week, if nobody has objections,
I'll merge your patch (and I can add the comment myself).

Thanks,

Simon