From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WLMIMrriI2F5NgAAWB0awg (envelope-from ) for ; Mon, 23 Aug 2021 14:02:34 -0400 Received: by simark.ca (Postfix, from userid 112) id CAE1E1EE18; Mon, 23 Aug 2021 14:02:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D6721ECEB for ; Mon, 23 Aug 2021 14:02:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10339385782C for ; Mon, 23 Aug 2021 18:02:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10339385782C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629741754; bh=vxA7MRVHdB5ChrkP1KcCEafbdn+dY4ousz+CA2pTXKI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=epOa7savGLwhOR/0UrUTdXCvpM8+c5GzGTJCiWnLtBYAv77uZqE5uGDJUK9balPwX rkmI06jnr0fzOT4GcTjR+ftslN7sjQtqjSB1vrB4TiVQ5/Du7dhVeuYFV9+G3fpM9g KUMnYdSvsbZmFRQHqVn3GbCS3Eyvv9EH40YQk2/0= Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id 08DFF3858C2C for ; Mon, 23 Aug 2021 18:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08DFF3858C2C Received: from patrick.monnerat (56.82.193.178.dynamic.wline.res.cust.swisscom.ch [178.193.82.56]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 17NI1nnM004546 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Aug 2021 20:01:54 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 17NI1nnM004546 Subject: Re: [PATCH] Replace deprecated_target_wait_hook by an observer To: Simon Marchi , gdb-patches@sourceware.org References: <20210822164256.144875-1-patrick@monnerat.net> <934649d9-1f4a-0b3c-a6de-5641c49bb0c6@monnerat.net> <5697ed83-dd71-c977-9f04-cffa75751c23@polymtl.ca> Message-ID: <723fdf83-3fb9-4c77-09c9-f33c1faa98a7@monnerat.net> Date: Mon, 23 Aug 2021 20:01:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5697ed83-dd71-c977-9f04-cffa75751c23@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Patrick Monnerat via Gdb-patches Reply-To: Patrick Monnerat Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 8/23/21 7:48 PM, Simon Marchi wrote: >> For more details, see Insight commit https://sourceware.org/git/?p=insight.git;a=commit;h=16042bf > Thanks, that clarifies why you need it to be called both before and > after. > > I think it would be good to add some comment above where the obsserver > is notified to say that this is used by Insight, otherwise someone might > be tempted to remove it, as it is unused in the GDB project itself. > > I suggest leaving the review up for a week, if nobody has objections, > I'll merge your patch (and I can add the comment myself). That's fine for me, thanks. Patrick