Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Pedro Alves" <pedro@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: RE: Also allow -list-thread-groups (--available) without a live selected thread
Date: Wed, 14 Jan 2009 15:06:00 -0000	[thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <200901141428.53828.pedro@codesourcery.com>

Hi,

I had a quick look at the patch and I wanted to mention
that the parentheses are kind of weird.  Don't get me wrong,
they do work, but there is some weird and unnecessary groupings
of conditions, if that matters.

Thanks for the patch though, I will use it.

Marc


> -----Original Message-----
> From: gdb-patches-owner@sourceware.org 
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, January 14, 2009 9:29 AM
> To: gdb-patches@sourceware.org
> Subject: Also allow -list-thread-groups (--available) without 
> a live selected thread
> 
> Similarly to -thread-info, -thread-list-ids, 
> -list-thread-groups (--available)
> should always be issuable without a live selected thread.
> 
> I tested it in non-stop mode, and all-stop sync/async as well with
> success, with an exited thread selected.
> 
> In the all-stop async case, '-list-thread-groups' always works,
> even if the target is running, because it isn't (currently) asking
> the remote side for anything.  OTOH, '-list-thread-groups 
> --available' will
> error out with "Cannot execute this command while the target 
> is running.",
> which is expected due to limitations of the all-stop remote protocol
> (same error as given by -thread-info).  In non-stop mode, it always
> works.
> 
> Checked in.
> 
> -- 
> Pedro Alves
> 


  reply	other threads:[~2009-01-14 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 14:29 Pedro Alves
2009-01-14 15:06 ` Marc Khouzam [this message]
2009-01-14 15:22   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se \
    --to=marc.khouzam@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox