From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14078 invoked by alias); 14 Jan 2009 15:06:25 -0000 Received: (qmail 14069 invoked by uid 22791); 14 Jan 2009 15:06:25 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jan 2009 15:05:39 +0000 Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id n0EFAeP8008274; Wed, 14 Jan 2009 09:10:40 -0600 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Wed, 14 Jan 2009 09:05:36 -0600 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: Also allow -list-thread-groups (--available) without a live selected thread Date: Wed, 14 Jan 2009 15:06:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <200901141428.53828.pedro@codesourcery.com> References: <200901141428.53828.pedro@codesourcery.com> From: "Marc Khouzam" To: "Pedro Alves" , X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00318.txt.bz2 Hi, I had a quick look at the patch and I wanted to mention that the parentheses are kind of weird. Don't get me wrong, they do work, but there is some weird and unnecessary groupings of conditions, if that matters. Thanks for the patch though, I will use it. Marc > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Wednesday, January 14, 2009 9:29 AM > To: gdb-patches@sourceware.org > Subject: Also allow -list-thread-groups (--available) without=20 > a live selected thread >=20 > Similarly to -thread-info, -thread-list-ids,=20 > -list-thread-groups (--available) > should always be issuable without a live selected thread. >=20 > I tested it in non-stop mode, and all-stop sync/async as well with > success, with an exited thread selected. >=20 > In the all-stop async case, '-list-thread-groups' always works, > even if the target is running, because it isn't (currently) asking > the remote side for anything. OTOH, '-list-thread-groups=20 > --available' will > error out with "Cannot execute this command while the target=20 > is running.", > which is expected due to limitations of the all-stop remote protocol > (same error as given by -thread-info). In non-stop mode, it always > works. >=20 > Checked in. >=20 > --=20 > Pedro Alves >=20