RE: Also allow -list-thread-groups (--available) without a live selected thread

Marc Khouzam
2009-01-14T15:06:25Z

Hi,

I had a quick look at the patch and I wanted to mention
that the parentheses are kind of weird. Don't get me wrong,
they do work, but there is some weird and unnecessary groupings
of conditions, if that matters.

Thanks for the patch though, I will use it.

Marc

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, January 14, 2009 9:29 AM
> To: gdb-patches@sourceware.org
> Subject: Also allow -list-thread-groups (--available) without
> a live selected thread
>
> Similarly to -thread-info, -thread-list-ids,
> -list-thread-groups (--available)
> should always be issuable without a live selected thread.
>
> I tested it in non-stop mode, and all-stop sync/async as well with
> success, with an exited thread selected.
>
> In the all-stop async case, '-list-thread-groups' always works,
> even if the target is running, because it isn't (currently) asking
> the remote side for anything. OTOH, '-list-thread-groups
> --available' will
> error out with "Cannot execute this command while the target
> is running.",
> which is expected due to limitations of the all-stop remote protocol
> (same error as given by -thread-info). In non-stop mode, it always
> works.
>
> Checked in.
>
> --
> Pedro Alves
>