Re: Also allow -list-thread-groups (--available) without a live selected thread

Pedro Alves
2009-01-14T15:22:58Z

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

On Wednesday 14 January 2009 15:05:34, Marc Khouzam wrote:

> I had a quick look at the patch and I wanted to mention
> that the parentheses are kind of weird. Don't get me wrong,
> they do work, but there is some weird and unnecessary groupings
> of conditions, if that matters.

Eh, it took me a moment to spot it. Oh man, the simplest things...

I've fixed it now. Thanks!

--
Pedro Alves

[-- Attachment #2: fix_parens.diff --]
[-- Type: text/x-diff, Size: 1053 bytes --]

2009-01-14 Pedro Alves <pedro@codesourcery.com>

* mi/mi-main.c (mi_cmd_execute): Clean up parenthesis mess from
previous change.

---
gdb/mi/mi-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Index: src/gdb/mi/mi-main.c
===================================================================
--- src.orig/gdb/mi/mi-main.c 2009-01-14 15:16:04.000000000 +0000
+++ src/gdb/mi/mi-main.c 2009-01-14 15:16:53.000000000 +0000
@@ -1352,11 +1352,11 @@ mi_cmd_execute (struct mi_parse *parse)
{
if (target_can_async_p ()
&& target_has_execution
- && (is_exited (inferior_ptid))
+ && is_exited (inferior_ptid)
&& (strcmp (parse->command, "thread-info") != 0
&& strcmp (parse->command, "thread-list-ids") != 0
- && strcmp (parse->command, "thread-select") != 0)
- && strcmp (parse->command, "list-thread-groups") != 0)
+ && strcmp (parse->command, "thread-select") != 0
+ && strcmp (parse->command, "list-thread-groups") != 0))
{
struct ui_file *stb;
stb = mem_fileopen ();