From: Pedro Alves <pedro@codesourcery.com>
To: "Marc Khouzam" <marc.khouzam@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Also allow -list-thread-groups (--available) without a live selected thread
Date: Wed, 14 Jan 2009 15:22:00 -0000 [thread overview]
Message-ID: <200901141522.45202.pedro@codesourcery.com> (raw)
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Wednesday 14 January 2009 15:05:34, Marc Khouzam wrote:
> I had a quick look at the patch and I wanted to mention
> that the parentheses are kind of weird. Don't get me wrong,
> they do work, but there is some weird and unnecessary groupings
> of conditions, if that matters.
Eh, it took me a moment to spot it. Oh man, the simplest things...
I've fixed it now. Thanks!
--
Pedro Alves
[-- Attachment #2: fix_parens.diff --]
[-- Type: text/x-diff, Size: 1053 bytes --]
2009-01-14 Pedro Alves <pedro@codesourcery.com>
* mi/mi-main.c (mi_cmd_execute): Clean up parenthesis mess from
previous change.
---
gdb/mi/mi-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: src/gdb/mi/mi-main.c
===================================================================
--- src.orig/gdb/mi/mi-main.c 2009-01-14 15:16:04.000000000 +0000
+++ src/gdb/mi/mi-main.c 2009-01-14 15:16:53.000000000 +0000
@@ -1352,11 +1352,11 @@ mi_cmd_execute (struct mi_parse *parse)
{
if (target_can_async_p ()
&& target_has_execution
- && (is_exited (inferior_ptid))
+ && is_exited (inferior_ptid)
&& (strcmp (parse->command, "thread-info") != 0
&& strcmp (parse->command, "thread-list-ids") != 0
- && strcmp (parse->command, "thread-select") != 0)
- && strcmp (parse->command, "list-thread-groups") != 0)
+ && strcmp (parse->command, "thread-select") != 0
+ && strcmp (parse->command, "list-thread-groups") != 0))
{
struct ui_file *stb;
stb = mem_fileopen ();
prev parent reply other threads:[~2009-01-14 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:29 Pedro Alves
2009-01-14 15:06 ` Marc Khouzam
2009-01-14 15:22 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901141522.45202.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox