From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28668 invoked by alias); 14 Jan 2009 15:22:58 -0000 Received: (qmail 28659 invoked by uid 22791); 14 Jan 2009 15:22:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jan 2009 15:22:20 +0000 Received: (qmail 17594 invoked from network); 14 Jan 2009 15:22:18 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Jan 2009 15:22:18 -0000 From: Pedro Alves To: "Marc Khouzam" Subject: Re: Also allow -list-thread-groups (--available) without a live selected thread Date: Wed, 14 Jan 2009 15:22:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200901141428.53828.pedro@codesourcery.com> <6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA06C22168@ecamlmw720.eamcs.ericsson.se> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_FNgbJV6VGA/2NK7" Message-Id: <200901141522.45202.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00322.txt.bz2 --Boundary-00=_FNgbJV6VGA/2NK7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 396 On Wednesday 14 January 2009 15:05:34, Marc Khouzam wrote: > I had a quick look at the patch and I wanted to mention > that the parentheses are kind of weird. Don't get me wrong, > they do work, but there is some weird and unnecessary groupings > of conditions, if that matters. Eh, it took me a moment to spot it. Oh man, the simplest things... I've fixed it now. Thanks! -- Pedro Alves --Boundary-00=_FNgbJV6VGA/2NK7 Content-Type: text/x-diff; charset="iso 8859-15"; name="fix_parens.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_parens.diff" Content-length: 1053 2009-01-14 Pedro Alves * mi/mi-main.c (mi_cmd_execute): Clean up parenthesis mess from previous change. --- gdb/mi/mi-main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: src/gdb/mi/mi-main.c =================================================================== --- src.orig/gdb/mi/mi-main.c 2009-01-14 15:16:04.000000000 +0000 +++ src/gdb/mi/mi-main.c 2009-01-14 15:16:53.000000000 +0000 @@ -1352,11 +1352,11 @@ mi_cmd_execute (struct mi_parse *parse) { if (target_can_async_p () && target_has_execution - && (is_exited (inferior_ptid)) + && is_exited (inferior_ptid) && (strcmp (parse->command, "thread-info") != 0 && strcmp (parse->command, "thread-list-ids") != 0 - && strcmp (parse->command, "thread-select") != 0) - && strcmp (parse->command, "list-thread-groups") != 0) + && strcmp (parse->command, "thread-select") != 0 + && strcmp (parse->command, "list-thread-groups") != 0)) { struct ui_file *stb; stb = mem_fileopen (); --Boundary-00=_FNgbJV6VGA/2NK7--