Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Vladimir Prus" <ghost@cs.msu.su>, <gdb-patches@sources.redhat.com>
Subject: RE: [Patch] -var-evaluate-expression NAME [FORMAT]
Date: Sun, 03 Feb 2008 19:55:00 -0000	[thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <E1JLGPo-0002eW-4k@zigzag.lvk.cs.msu.su>

> I honestly don't like this 'set global format, then cleanup'
> trick, but that's something we can fix later.

There was another suggested solution in:
http://sourceware.org/ml/gdb-patches/2008-01/msg00531.html
But it seemed like too much impact.

> > -          else  if (var->value == NULL && value == NULL)
> > +         else  if (var->value == NULL && value == NULL)
> 
> Did you do something about indentation here?

I went through the file and replaced any starting sequence of
8 spaces with a tab.  I hesitated at changing parts of the file
I didn't actually change, but since they were minor changes,
I though it would make the file more readable.

[...]
> > if (mi_version (uiout) > 1)
> > -        do_cleanups (cleanup);
> > +       do_cleanups (cleanup);
> 
> Lots of reformatting here as well. The patch looks otherwise
> good to me.

All these reformats are replacing 8 spaces with tabs.

Unless you guys want me to revert that extra reformatting, 
I guess the patch is good?  
Who's gonna apply it? :-)

Thanks

Marc 


  reply	other threads:[~2008-02-03 19:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 20:38 Marc Khouzam
2008-01-23  3:04 ` Nick Roberts
2008-01-23 14:30   ` Marc Khouzam
2008-01-23 14:42     ` Daniel Jacobowitz
2008-01-23 17:04       ` Marc Khouzam
2008-01-23 22:09         ` Nick Roberts
2008-01-24 21:36           ` Marc Khouzam
2008-01-25  9:59             ` Eli Zaretskii
2008-01-29 21:45             ` Daniel Jacobowitz
2008-02-01 19:23               ` Marc Khouzam
2008-02-02 10:31                 ` Eli Zaretskii
2008-02-03 19:43                   ` Marc Khouzam
2008-02-03 20:01                     ` Eli Zaretskii
2008-02-04 14:17                       ` Marc Khouzam
2008-02-04 21:00                         ` Eli Zaretskii
2008-02-02 11:20                 ` Vladimir Prus
2008-02-03 19:55                   ` Marc Khouzam [this message]
2008-02-03 20:42                     ` Joel Brobecker
2008-02-03 21:41                       ` Daniel Jacobowitz
2008-02-03 21:46                 ` Daniel Jacobowitz
2008-02-04 17:00                   ` Marc Khouzam
2008-02-04 17:02                   ` Marc Khouzam
2008-02-04 21:40                     ` Nick Roberts
2008-02-04 21:53                       ` Nick Roberts
2008-02-05 14:47                       ` Marc Khouzam
2008-02-05 20:43                         ` Nick Roberts
2008-02-05 20:55                           ` Marc Khouzam
2008-02-05 21:18                             ` Nick Roberts
2008-02-04 17:11                   ` Marc Khouzam
2008-01-23  3:48 ` Daniel Jacobowitz
2008-01-23 14:44   ` Marc Khouzam
2008-01-28 14:41 Marc Khouzam
2008-01-28 14:48 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se \
    --to=marc.khouzam@ericsson.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox